Skip to content

- Fix order of learners in generateLearningCurveData() #2768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 15, 2020

Conversation

jakob-r
Copy link
Member

@jakob-r jakob-r commented Jun 15, 2020

Fixes issue #2767 and generally cleans up the code a bit to avoid wrong orderings of each column.

Copy link
Member

@pat-s pat-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I assume you checked against R 3.6 and R 4.0? Good to go from my side. A NEWS entry would be great.

@jakob-r
Copy link
Member Author

jakob-r commented Jun 15, 2020

I added a NEWS entry. However, I did not check against R 3.6. The new solution does not use anything that is critical in this regard.

@pat-s
Copy link
Member

pat-s commented Jun 15, 2020

Ok, fair enough. Let's assume its fixed for now if there are no new reports incoming. No time to write a test for this now.

@pat-s pat-s changed the title Fix order of learners in generateLearningCurveData (Fixes #2767) - Fix order of learners in generateLearningCurveData() Jun 15, 2020
@pat-s pat-s merged commit f0ff626 into master Jun 15, 2020
@pat-s pat-s deleted the fix_2767_generateLearningCurve branch June 15, 2020 15:13
vrodriguezf pushed a commit to vrodriguezf/mlr that referenced this pull request Jan 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants