Skip to content

Fixed i18n translation files with ESM and vite. #1017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

mikevandiepen
Copy link

@mikevandiepen mikevandiepen commented Apr 28, 2025

Merge request checklist

  • I read the guidelines for contributing
  • I created my branch from dev and I am issuing the PR to dev
  • I didn't pushed the dist directory
  • If it's a new feature, I added the necessary unit tests
  • If it's a new language, I filled the __locale and __author fields

🗒️ There where issues where jquery wasn't globally accessible when initializing jquery-builder, adding window.$ solved the problem. i18n files cannot be imported using ESM and vite.

@mikevandiepen mikevandiepen changed the title Couldn't access globally defined jquery instance when using vite Fixed i18n translation files with ESM and vite. Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant