Feat/ffi provider mike #1
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: message provider implementation * feat: add basic verify flow * feat: add missing flask config * feat: initial flask start setup * feat: and sample provider test, rename MessageProvider constructor * feat: move handler to provider * feat: pass handler as python argument * feat: pass handler as python argument * feat: create setup endpoint for message handlers, add setup_state fn, refactor test * feat: enable context manager in message provider, allow provider to pass Proxy port param, new endpoints to stop/check proxy * fix: flake8 * fix: revert bad merge to http_proxy; add pydocstyle * feat: parse content, update readme and test * test: add missing tests for message provider * fix: check the pact files exists before running the vefivication * fix: flake8 * feat: rebase feature from master branch * fix: remove dead code * feat: add http_proxy test, replace print with log, use flask localstack to store states * fix: change PROXY_PORT to 1234 to fix broken build * fix: flake8 * chore: skip provider test to make the build pass (troubleshooting) * chore: skip 2 tests that causes BrokenPipeError for investigation * chore: comment out the broken tests * fix: change default proxy port to 1234 * feat: updated message consumer test to be compatible with message provider test * fix: Updated tests that where failing on master branch as well * feat: ported message_provider to fastapi * fix: fixed comment * fix: removed unnecessary pact file updated flask * fix: added detectcontentlambda-contentprovider.json to .gitignore Co-authored-by: Tuan Pham <q.tuan.p@gmail.com> Co-authored-by: William Infante <williaminfante@gmail.com>
…e changes to docker37 which I will need to do to all
…ing by the tox list)
The return code is straightforward, but having problems with the logging. When setting up the FFI objects etc, it doesn't seem to work unless it's a basically a singleton, it seems hard to split up. I don't like it but going with this for now :)
mikegeeves
commented
Aug 21, 2021
| elif 'linux' in target_platform: | ||
| libname = "pact/bin/libpact_ffi-linux-x86_64.so" | ||
| elif 'windows' in target_platform: | ||
| libname = "pact/bin/pact_ffi-windows-x86_64.dll" |
There was a problem hiding this comment.
This had the osx lib, think this is correct but no Windows to check it actually works
mikegeeves
commented
Aug 21, 2021
pact/ffi/verifier.py
Outdated
| else: | ||
| c_args = self.ffi.NULL | ||
|
|
||
| # This fails if called a second time after the library has been loaded |
There was a problem hiding this comment.
TODO: pull this out before merging, I wanted to try and setup to initialise the library for each call so it is completely independent, but wasn't able to get that to work
mikegeeves
commented
Aug 21, 2021
| <!-- Absolute link for rendering page in docs.pact.io --> | ||
| Please read [CONTRIBUTING.md](https://github.com/pact-foundation/pact-python/blob/master/CONTRIBUTING.md) | ||
|
|
||
| To setup a development environment: | ||
|
|
||
| 1. If you want to run tests for all Python versions, install 2.7, 3.3, 3.4, 3.5, and 3.6 from source or using a tool like [pyenv] |
There was a problem hiding this comment.
Matching up with the list in tox.ini
Install all ruby standalone packages when running sdist. Devloppers can also now provide a --bin-path that contains the binaries required for their OS, so that can they use this package in offline environments.
…fi_free_string to cleanup
…dation#257) * feat: added support for message provider using pact broker * fix: added new line * fix: update tests to support pact-broker runs fix: updated message_pact to wait writing contract process to finish * fix: removed time from import
…ation of a simple pact
…s/pact-python into feat/ffi-provider-mike
…here (merge from master)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.