Todo changes for coverlet inproc datacollector #2020
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singhsarab
reviewed
May 29, 2019
| /// <summary> | ||
| /// Coverlet inproc data collector codebase | ||
| /// </summary> | ||
| public const string CoverletDataCollectorCodebase = "coverletinprocdatacollector.dll"; | ||
| public const string CoverletDataCollectorCodebase = "coverlet.collector.dll"; |
There was a problem hiding this comment.
What is the name of the out proc one ?
There was a problem hiding this comment.
There is only one dll coverlet.collector. The inproc datacollector is inside this in a separate folder.
Link: https://github.com/tonerdo/coverlet/tree/master/src/coverlet.collector
There was a problem hiding this comment.
The publicKeyToken can be removed if null
There was a problem hiding this comment.
Guys if I clone repo and do some update on public key...is there a guide that explain how to run my local "dotnet test" driver?
If so I could test on my local if there are issue with collector load and do a PR directly to this repo.
Related PR coverlet-coverage/coverlet#566
cltshivash
approved these changes
Jun 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Todo changes for coverlet inproc datacollector
Related PR
#1969