chore: use yarn pnpm mode #2366
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Opened facebook#50280 upstream to fix one issue I see |
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Mar 26, 2025
Summary: The React Native monorepo depends on `jest-config` in `jest.config.js` but does not specify it as a dependency. This means we got it as a phantom / transitive dependency. In React Native macOS, I am testing using Yarn 4 with pnpm layout to protect against such dependencies (See microsoft#2366). The simplest way to fix this is to just declare it as a dependency. ## Changelog: [INTERNAL] [FIXED] - Add jest-config as a dependency Pull Request resolved: #50280 Test Plan: This change should be a no-op in React Native, we already had the package in our lock. Reviewed By: yungsters, huntie Differential Revision: D71891841 Pulled By: robhogan fbshipit-source-id: 5b4720e9e09e25b2f1eebb80675bfe4f3a48e2dc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todo:
yarn startin rn-tester fails. Technically it has failed for a while, but now the workaround of runningnpc react-native-macos startalso doesn't work. In other words, this PR will probably force us to go fix that bug.Summary:
Attempt to use yarn's pnpm linker for React Native macOS. This should help catch ghost dependencies better, and matches our internal setup slightly better. It should also help us catch issues in React Native Core that we can then push fixes for.
Test Plan:
CI should pass