-
Notifications
You must be signed in to change notification settings - Fork 48
Chore: Update react-native-lottie #473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
CI is failing with this:
Perhaps that patch file that was removed is still needed? |
It seems so. I removed the patch to see if the latest version had the fix. Glad to see the CI caught it doesn't. I'll update the patch to reflect the new version with the changes. |
@Saadnajmi This PR is still sitting open after many months. Were you able to resolve the CI issue? |
/azp run |
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
@chrisglein I'll take a look next week when I'm near a computer. Otherwise we can probably close it |
Description
Why
Our version of Lottie doesn't support macOS
What
Update Lottie to the latest, which does support macOS
Microsoft Reviewers: Open in CodeFlow