Skip to content

Chore: Update react-native-lottie #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Saadnajmi
Copy link
Contributor

@Saadnajmi Saadnajmi commented Jul 9, 2024

Description

Why

Our version of Lottie doesn't support macOS

What

Update Lottie to the latest, which does support macOS

Microsoft Reviewers: Open in CodeFlow

@chrisglein
Copy link
Member

CI is failing with this:

C:\Program Files\Microsoft Visual Studio\2022\Enterprise\Common7\IDE\CommonExtensions\Microsoft\NuGet\NuGet.targets(414,5): error MSB3202: The project file "D:\a_work\1\s\node_modules\lottie-react-native\src\windows\cppwinrt\LottieReactNative.vcxproj" was not found. [D:\a_work\1\s\windows\rngallery.sln]

Perhaps that patch file that was removed is still needed?

@Saadnajmi
Copy link
Contributor Author

CI is failing with this:

C:\Program Files\Microsoft Visual Studio\2022\Enterprise\Common7\IDE\CommonExtensions\Microsoft\NuGet\NuGet.targets(414,5): error MSB3202: The project file "D:\a_work\1\s\node_modules\lottie-react-native\src\windows\cppwinrt\LottieReactNative.vcxproj" was not found. [D:\a_work\1\s\windows\rngallery.sln]

Perhaps that patch file that was removed is still needed?

It seems so. I removed the patch to see if the latest version had the fix. Glad to see the CI caught it doesn't. I'll update the patch to reflect the new version with the changes.

@chrisglein
Copy link
Member

@Saadnajmi This PR is still sitting open after many months. Were you able to resolve the CI issue?

@Saadnajmi
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

@Saadnajmi
Copy link
Contributor Author

@chrisglein I'll take a look next week when I'm near a computer. Otherwise we can probably close it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants