DOM update 2024-07-12 #59259
Merged
DOM update 2024-07-12 #59259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm doing this early in preparation for adding `/** @deferred */` comments on callbacks for 5.6.
typescript-bot
added
Author: Team
For Uncommitted Bug
|
@typescript-bot test this |
|
@typescript-bot test it |
jakebailey
reviewed
Jul 12, 2024
Comment on lines
-12108
to
-12112
| /** | ||
| * Sets or retrieves a value that you can use to implement your own label functionality for the object. | ||
| * | ||
| * [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLOptGroupElement/label) | ||
| */ |
There was a problem hiding this comment.
Why did so many props lose their MDN links?
There was a problem hiding this comment.
They probably have done page cleanup, and for example this link is now 404 (or has always been). Found this relevant PR mdn/browser-compat-data#23481
|
Hey @sandersn, the results of running the DT tests are ready. There were interesting changes: Branch only errors:Package: dom-view-transitions Package: chrome-apps Package: node/v16 Package: node/v18 |
|
@sandersn Here are the results of running the user tests with tsc comparing Something interesting changed - please have a look. Details
|
|
This is scary: |
|
@sandersn Here they are:
tscComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
Developer Information: |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
@sandersn Here are the results of running the top 400 repos with tsc comparing Something interesting changed - please have a look. Details
|
|
This PR adds ImportMeta.resolve as a non-optional method: interface ImportMeta {
url: string;
resolve(specifier: string): string;
}But |
|
After discussing with @andrewbranch we decided to make ImportMeta.resolve required in node 16 and 18 as well. Forcing a null check before usage isn't the right way to handle experimental features in the first place. I'd prefer to delete The correct way would have been to have a separate experimental package, probably. |
|
DefinitelyTyped/DefinitelyTyped#70054 is merged now, so I'm going to merge this after resolving the baseline conflict. |
This was referenced Jul 19, 2024
trevorade
added a commit
to trevorade/DefinitelyTyped
that referenced
this pull request
Aug 15, 2024
This is consistent with both the API: https://developer.mozilla.org/en-US/docs/Web/API/Element/requestPointerLock#return_value As well as its upcoming inclusion in TypeScript's built-in types for requestPointerLock: https://github.com/microsoft/TypeScript/blob/90da3ca5dd694f7029b535ea09727be899854d40/src/lib/dom.generated.d.ts#L7873 Which was added here: microsoft/TypeScript#59259
JDevlieghere
added a commit
to JDevlieghere/llvm-project
that referenced
this pull request
Feb 13, 2025
Upgrade @types/node to work around an issue in TypeScript [1] that caused our "publish to VSCode Marketplace" github action [2] to fail: ``` node_modules/@types/node/module.d.ts:290:13 - error TS2386: Overload signatures must all be optional or required. 290 resolve?(specified: string, parent?: string | URL): Promise<string>; ``` [1] microsoft/TypeScript#59259 (comment) [2] https://github.com/llvm/vscode-lldb/actions/runs/13298213337/job/37134713009
JDevlieghere
added a commit
to llvm/llvm-project
that referenced
this pull request
Feb 13, 2025
…6994) Upgrade @types/node to work around an issue in TypeScript [1] that caused our "publish to VSCode Marketplace" github action [2] to fail: ``` node_modules/@types/node/module.d.ts:290:13 - error TS2386: Overload signatures must all be optional or required. 290 resolve?(specified: string, parent?: string | URL): Promise<string>; ``` [1] microsoft/TypeScript#59259 (comment) [2] https://github.com/llvm/vscode-lldb/actions/runs/13298213337/job/37134713009
github-actions bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
Feb 13, 2025
…e.d.ts (#126994) Upgrade @types/node to work around an issue in TypeScript [1] that caused our "publish to VSCode Marketplace" github action [2] to fail: ``` node_modules/@types/node/module.d.ts:290:13 - error TS2386: Overload signatures must all be optional or required. 290 resolve?(specified: string, parent?: string | URL): Promise<string>; ``` [1] microsoft/TypeScript#59259 (comment) [2] https://github.com/llvm/vscode-lldb/actions/runs/13298213337/job/37134713009
flovent
pushed a commit
to flovent/llvm-project
that referenced
this pull request
Feb 13, 2025
…m#126994) Upgrade @types/node to work around an issue in TypeScript [1] that caused our "publish to VSCode Marketplace" github action [2] to fail: ``` node_modules/@types/node/module.d.ts:290:13 - error TS2386: Overload signatures must all be optional or required. 290 resolve?(specified: string, parent?: string | URL): Promise<string>; ``` [1] microsoft/TypeScript#59259 (comment) [2] https://github.com/llvm/vscode-lldb/actions/runs/13298213337/job/37134713009
joaosaffran
pushed a commit
to joaosaffran/llvm-project
that referenced
this pull request
Feb 14, 2025
…m#126994) Upgrade @types/node to work around an issue in TypeScript [1] that caused our "publish to VSCode Marketplace" github action [2] to fail: ``` node_modules/@types/node/module.d.ts:290:13 - error TS2386: Overload signatures must all be optional or required. 290 resolve?(specified: string, parent?: string | URL): Promise<string>; ``` [1] microsoft/TypeScript#59259 (comment) [2] https://github.com/llvm/vscode-lldb/actions/runs/13298213337/job/37134713009
sivan-shani
pushed a commit
to sivan-shani/llvm-project
that referenced
this pull request
Feb 24, 2025
…m#126994) Upgrade @types/node to work around an issue in TypeScript [1] that caused our "publish to VSCode Marketplace" github action [2] to fail: ``` node_modules/@types/node/module.d.ts:290:13 - error TS2386: Overload signatures must all be optional or required. 290 resolve?(specified: string, parent?: string | URL): Promise<string>; ``` [1] microsoft/TypeScript#59259 (comment) [2] https://github.com/llvm/vscode-lldb/actions/runs/13298213337/job/37134713009
SquallATF
pushed a commit
to SquallATF/llvm-project
that referenced
this pull request
Mar 8, 2025
…m#126994) Upgrade @types/node to work around an issue in TypeScript [1] that caused our "publish to VSCode Marketplace" github action [2] to fail: ``` node_modules/@types/node/module.d.ts:290:13 - error TS2386: Overload signatures must all be optional or required. 290 resolve?(specified: string, parent?: string | URL): Promise<string>; ``` [1] microsoft/TypeScript#59259 (comment) [2] https://github.com/llvm/vscode-lldb/actions/runs/13298213337/job/37134713009
SquallATF
pushed a commit
to SquallATF/llvm-project
that referenced
this pull request
Mar 20, 2025
…m#126994) Upgrade @types/node to work around an issue in TypeScript [1] that caused our "publish to VSCode Marketplace" github action [2] to fail: ``` node_modules/@types/node/module.d.ts:290:13 - error TS2386: Overload signatures must all be optional or required. 290 resolve?(specified: string, parent?: string | URL): Promise<string>; ``` [1] microsoft/TypeScript#59259 (comment) [2] https://github.com/llvm/vscode-lldb/actions/runs/13298213337/job/37134713009
SquallATF
pushed a commit
to SquallATF/llvm-project
that referenced
this pull request
Apr 2, 2025
…m#126994) Upgrade @types/node to work around an issue in TypeScript [1] that caused our "publish to VSCode Marketplace" github action [2] to fail: ``` node_modules/@types/node/module.d.ts:290:13 - error TS2386: Overload signatures must all be optional or required. 290 resolve?(specified: string, parent?: string | URL): Promise<string>; ``` [1] microsoft/TypeScript#59259 (comment) [2] https://github.com/llvm/vscode-lldb/actions/runs/13298213337/job/37134713009
SquallATF
pushed a commit
to SquallATF/llvm-project
that referenced
this pull request
Apr 17, 2025
…m#126994) Upgrade @types/node to work around an issue in TypeScript [1] that caused our "publish to VSCode Marketplace" github action [2] to fail: ``` node_modules/@types/node/module.d.ts:290:13 - error TS2386: Overload signatures must all be optional or required. 290 resolve?(specified: string, parent?: string | URL): Promise<string>; ``` [1] microsoft/TypeScript#59259 (comment) [2] https://github.com/llvm/vscode-lldb/actions/runs/13298213337/job/37134713009
SquallATF
pushed a commit
to SquallATF/llvm-project
that referenced
this pull request
Apr 30, 2025
…m#126994) Upgrade @types/node to work around an issue in TypeScript [1] that caused our "publish to VSCode Marketplace" github action [2] to fail: ``` node_modules/@types/node/module.d.ts:290:13 - error TS2386: Overload signatures must all be optional or required. 290 resolve?(specified: string, parent?: string | URL): Promise<string>; ``` [1] microsoft/TypeScript#59259 (comment) [2] https://github.com/llvm/vscode-lldb/actions/runs/13298213337/job/37134713009
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm doing this early in preparation for adding
/** @deferred */comments on callbacks for 5.6.Changes:
string | URLTest baseline changes: