Skip to content

Add an extra test case for deferred conditional types #52094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add an extra test case for deferred conditional types #52094

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion tests/baselines/reference/deferredConditionalTypes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,24 @@ type Extends<A, B> = A extends B ? true : false;
type IsNumberLiteral<T> = And<Extends<T, number>, Not<Extends<number, T>>>;

type IsLiteral<T> = Or<false, IsNumberLiteral<T>>;


// Repro from #51145#issuecomment-1276804047

type Values<O extends object> =
O extends any[]
? O[number]
: O[keyof O]

type Equals<A, B> = [A, B] extends [B, A] ? true : false;

type FilterByStringValue<O extends object> = {
[K in keyof O as Equals<O[K], string> extends true ? K : never]: any
}

type FilteredValuesMatchNever<O extends object>
= Equals<Values<FilterByStringValue<[O]>>, never>

type FilteredRes1 = FilteredValuesMatchNever<[]>

//// [deferredConditionalTypes.js]
"use strict";
52 changes: 52 additions & 0 deletions tests/baselines/reference/deferredConditionalTypes.symbols
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,3 +94,55 @@ type IsLiteral<T> = Or<false, IsNumberLiteral<T>>;
>IsNumberLiteral : Symbol(IsNumberLiteral, Decl(deferredConditionalTypes.ts, 13, 48))
>T : Symbol(T, Decl(deferredConditionalTypes.ts, 17, 15))

// Repro from #51145#issuecomment-1276804047

type Values<O extends object> =
>Values : Symbol(Values, Decl(deferredConditionalTypes.ts, 17, 50))
>O : Symbol(O, Decl(deferredConditionalTypes.ts, 21, 12))

O extends any[]
>O : Symbol(O, Decl(deferredConditionalTypes.ts, 21, 12))

? O[number]
>O : Symbol(O, Decl(deferredConditionalTypes.ts, 21, 12))

: O[keyof O]
>O : Symbol(O, Decl(deferredConditionalTypes.ts, 21, 12))
>O : Symbol(O, Decl(deferredConditionalTypes.ts, 21, 12))

type Equals<A, B> = [A, B] extends [B, A] ? true : false;
>Equals : Symbol(Equals, Decl(deferredConditionalTypes.ts, 24, 16))
>A : Symbol(A, Decl(deferredConditionalTypes.ts, 26, 12))
>B : Symbol(B, Decl(deferredConditionalTypes.ts, 26, 14))
>A : Symbol(A, Decl(deferredConditionalTypes.ts, 26, 12))
>B : Symbol(B, Decl(deferredConditionalTypes.ts, 26, 14))
>B : Symbol(B, Decl(deferredConditionalTypes.ts, 26, 14))
>A : Symbol(A, Decl(deferredConditionalTypes.ts, 26, 12))

type FilterByStringValue<O extends object> = {
>FilterByStringValue : Symbol(FilterByStringValue, Decl(deferredConditionalTypes.ts, 26, 57))
>O : Symbol(O, Decl(deferredConditionalTypes.ts, 28, 25))

[K in keyof O as Equals<O[K], string> extends true ? K : never]: any
>K : Symbol(K, Decl(deferredConditionalTypes.ts, 29, 3))
>O : Symbol(O, Decl(deferredConditionalTypes.ts, 28, 25))
>Equals : Symbol(Equals, Decl(deferredConditionalTypes.ts, 24, 16))
>O : Symbol(O, Decl(deferredConditionalTypes.ts, 28, 25))
>K : Symbol(K, Decl(deferredConditionalTypes.ts, 29, 3))
>K : Symbol(K, Decl(deferredConditionalTypes.ts, 29, 3))
}

type FilteredValuesMatchNever<O extends object>
>FilteredValuesMatchNever : Symbol(FilteredValuesMatchNever, Decl(deferredConditionalTypes.ts, 30, 1))
>O : Symbol(O, Decl(deferredConditionalTypes.ts, 32, 30))

= Equals<Values<FilterByStringValue<[O]>>, never>
>Equals : Symbol(Equals, Decl(deferredConditionalTypes.ts, 24, 16))
>Values : Symbol(Values, Decl(deferredConditionalTypes.ts, 17, 50))
>FilterByStringValue : Symbol(FilterByStringValue, Decl(deferredConditionalTypes.ts, 26, 57))
>O : Symbol(O, Decl(deferredConditionalTypes.ts, 32, 30))

type FilteredRes1 = FilteredValuesMatchNever<[]>
>FilteredRes1 : Symbol(FilteredRes1, Decl(deferredConditionalTypes.ts, 33, 51))
>FilteredValuesMatchNever : Symbol(FilteredValuesMatchNever, Decl(deferredConditionalTypes.ts, 30, 1))

29 changes: 29 additions & 0 deletions tests/baselines/reference/deferredConditionalTypes.types
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,3 +63,32 @@ type IsLiteral<T> = Or<false, IsNumberLiteral<T>>;
>IsLiteral : IsLiteral<T>
>false : false

// Repro from #51145#issuecomment-1276804047

type Values<O extends object> =
>Values : Values<O>

O extends any[]
? O[number]
: O[keyof O]

type Equals<A, B> = [A, B] extends [B, A] ? true : false;
>Equals : Equals<A, B>
>true : true
>false : false

type FilterByStringValue<O extends object> = {
>FilterByStringValue : FilterByStringValue<O>

[K in keyof O as Equals<O[K], string> extends true ? K : never]: any
>true : true
}

type FilteredValuesMatchNever<O extends object>
>FilteredValuesMatchNever : FilteredValuesMatchNever<O>

= Equals<Values<FilterByStringValue<[O]>>, never>

type FilteredRes1 = FilteredValuesMatchNever<[]>
>FilteredRes1 : true

18 changes: 18 additions & 0 deletions tests/cases/compiler/deferredConditionalTypes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,21 @@ type Extends<A, B> = A extends B ? true : false;
type IsNumberLiteral<T> = And<Extends<T, number>, Not<Extends<number, T>>>;

type IsLiteral<T> = Or<false, IsNumberLiteral<T>>;

// Repro from #51145#issuecomment-1276804047
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note that this test case doesn't showcase that #51145 has been fixed - it's just a variant proposed by @RyanCavanaugh there that didn't work either


type Values<O extends object> =
O extends any[]
? O[number]
: O[keyof O]

type Equals<A, B> = [A, B] extends [B, A] ? true : false;

type FilterByStringValue<O extends object> = {
[K in keyof O as Equals<O[K], string> extends true ? K : never]: any
}

type FilteredValuesMatchNever<O extends object>
= Equals<Values<FilterByStringValue<[O]>>, never>

type FilteredRes1 = FilteredValuesMatchNever<[]>