Use system line ending in services compiler host

[csnover]

Fixes #1653.

Let me know where you want tests to go for the language services and I can add some if you’d like.

[msftclas]

Hi @csnover, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by Microsoft and real humans are currently evaluating your PR.

TTYL, MSBOT;

[DanielRosenwasser]

services.ts isn't supposed to depend on sys.ts as far as I understand. Might be better to parameterize createCompilerHost but that's kind of ugly. @mhegazy might be able to guide you better.

[Arnavion]

Wouldn't it be better to add a getNewLine() method to LanguageServiceHost (just like CompilerHost) and let the implementation provide it? You can continue defaulting to "\r\n" for backward-compat if the LanguageServiceHost implementation doesn't have a getNewLine()

[mhegazy]

The problem is that sys may not be defined, e.g. In a web page. I like @Arnavion idea. But I would make the new method optional in the interface and call it to initialize the value of the newline in createlamguageservice.

[csnover]

OK, that was the first option in the original bug. I will try to change this over the weekend to add an optional host method if someone else doesn’t get to it first.

[csnover]

The PR is updated for language service hosts to provide a getNewLine method instead. This API doesn’t feel great, but, well.

[mhegazy]

Thanks!