Stop prepending file:// to sourcemap paths #16183
Conversation
Submitting on behalf of mhegazy
|
@amcasey, |
|
@sandersn was going to confirm that this didn't break some other debugger scenarios. |
| @@ -321,9 +321,6 @@ function compileFile(outFile, sources, prereqs, prefixes, useBuiltCompiler, opts | |||
| } | |||
| else { | |||
| options += " -sourcemap"; | |||
| if (!opts.noMapRoot) { | |||
There was a problem hiding this comment.
you can now remove all references to noMapRoot in this file.
There was a problem hiding this comment.
Oops, missed this one. I'll create a separate PR.
|
I'm about to try it with the Chrome/Ubuntu/jake combination to make sure that it works. (I believe this combination was broken before and that only gulp worked.) I'll sign off when I confirm that it works. |
There was a problem hiding this comment.
This works, but it works differently than gulp. With jake, the source maps show up under built/local/src/compiler/checker.ts (for example). With gulp source maps show up udner src/compiler/checker.ts (for example).
This is a big improvement on not working at all!
Missed a comment in PR microsoft#16183
Submitting on behalf of @mhegazy.