Skip to content

consider type parameters always visible #1614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 7, 2015
Merged

Conversation

vladima
Copy link
Contributor

@vladima vladima commented Jan 7, 2015

Type parameters belong to the entity that declares them and don't have their own visibility so they should always considered public. Fixes #1445

@DanielRosenwasser
Copy link
Member

👍

2 similar comments
@CyrusNajmabadi
Copy link
Contributor

👍

@JsonFreeman
Copy link
Contributor

👍

vladima added a commit that referenced this pull request Jan 7, 2015
consider type parameters always visible
@vladima vladima merged commit 4daa107 into master Jan 7, 2015
@bluong
Copy link

bluong commented Jan 7, 2015

Noticed that the target branch is to master. Does that mean that release-1.4 will pick this fix up?

@vladima
Copy link
Contributor Author

vladima commented Jan 7, 2015

It was already cherry-picked to release-1.4

@vladima vladima deleted the type_parameters_visibility branch January 8, 2015 21:58
@microsoft microsoft locked and limited conversation to collaborators Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generic type parameters considered private in protected methods when generating .d.ts
5 participants