Fixes #1577 #1581
Merged
Fixes #1577 #1581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
Rebased onto latest master (no changes). |
|
👍 Thanks! (While it gets hard to figure out what should go in which file, it's ideal to break up the tests in the future.) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologies for the combinatorial explosion of tests but it was the easiest way to be sure.
Tests are for binary expressions of each type - same precedence (+, -), greater precedence (*) and lower precedence (&), for both outside and inside the template expression.
Emit was verified by running both ES5 emit and the original TS in Firefox Nightly (since it supports template strings) and comparing the results (both valid and invalid).