Skip to content

Use a separate field on a node to specify parser context flags. #1261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Nov 25, 2014
Merged

Use a separate field on a node to specify parser context flags. #1261

merged 20 commits into from
Nov 25, 2014

Conversation

CyrusNajmabadi
Copy link
Contributor

No description provided.

@CyrusNajmabadi
Use a separate field on a node to specify parser context flags.
f0b7315
@CyrusNajmabadi
Update fidelity to match names.
14f90b8
@CyrusNajmabadi
Extract context flags into their own enum.
8a61566
@CyrusNajmabadi
Add the context mutation operators.
726de4b
@CyrusNajmabadi
Add support for parsing generator functions and yield expressions.
7e1a62a
@CyrusNajmabadi
Parser tests for generators and yield expressions.
78cd1b5
@CyrusNajmabadi
Fix parsing of function expression names.
2f075a1
@CyrusNajmabadi
Add test baselines.
d11eabc
@CyrusNajmabadi
Add an _es6 suffix to prevent name collisions.
3b253e9
@CyrusNajmabadi
Don't store both boolean context flags and a unified flags value.
d2aa688
@CyrusNajmabadi
Initialize enum in a way that makes it clearer that it is a Flags-enum.
1bf3ba8
@CyrusNajmabadi
Rename methods as per CR feedback.
5309171
@CyrusNajmabadi
An asterisk is not a legal start of an enum member.
ed2cd99
@CyrusNajmabadi
Don't use underscores in names.
dac0a91
@CyrusNajmabadi
Rename parser context flags.
bdaccf6
@CyrusNajmabadi
Mark generator functions with an appropriate nodeflag.
626e90e
@CyrusNajmabadi
Simplify fidelity implementation of context flags.
8bbc409
@CyrusNajmabadi
Have a node flag to indicate if a yield expression has a *.
ce2e7fc
@CyrusNajmabadi
Add clarifying comments.
dc6886c
@CyrusNajmabadi
Improve comments for both parsers and bring more in sync.
3597f4f
CyrusNajmabadi added a commit that referenced this pull request Nov 25, 2014
@CyrusNajmabadi
Merge pull request #1261 from Microsoft/contextFlags
af4a121 
Use a separate field on a node to specify parser context flags.
@CyrusNajmabadi CyrusNajmabadi merged commit af4a121 into master Nov 25, 2014
@CyrusNajmabadi CyrusNajmabadi deleted the contextFlags branch November 25, 2014 09:38
@microsoft microsoft locked and limited conversation to collaborators Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CyrusNajmabadi @vladima