Wrong import suggestions for JavaScript default exports

[klaussner]

Does this issue occur when all extensions are disabled?: Yes

• VS Code Version: 1.90.0-insider (a48f464)
• OS Version: macOS Sonoma 14.4.1

If an npm package re-exports type definitions from nested paths, VS Code suggests wrong import paths for default exports. I noticed the issue when I tried to use packages from Atlassian's design system (e.g., @atlaskit/button), but I was able to reproduce it with a minimal example (see below).

Steps to Reproduce:

1. Clone this issue reproduction repository: https://github.com/klaussner/vs-code-import-issue
2. Follow the steps in README.md.

The video below shows how VS Code suggests the correct path for the named export, but the wrong path for the default export. The expected result is import defaultExport, { namedExport } from "example";.

VS.Code.import.issue.mp4

[klaussner]

Thank you for moving this to the right repository, @mjbvz. I didn't realize that the suggestions are coming from TypeScript.

I tracked down two commits related to the issue using git bisect:

• The auto import for re-exported default exports stopped working after this commit: 328e888 (pull request: Resolve module specifiers for auto imports in completion list (in incomplete chunks) #44713). After the commit, the suggestions for default exports still show up in the widget, but nothing happens when they are accepted (no import statement is added).
• This was fixed in 38076df (pull request: Fix auto import crash due to difference in paths handling #50419), but after this commit, the wrong path is used in the import statement, as shown in the video.

[klaussner]

Could someone from the TypeScript team confirm the issue, perhaps @andrewbranch (the author of the two pull requests I linked above)? Please let me know if there's anything I can do to help get this fixed.