Skip to content

Commit a48f464

Browse files
authored
Drop usage of inline chat services in notebook chat. (#212935)
1 parent 1d44987 commit a48f464

File tree

2 files changed

+159
-345
lines changed

2 files changed

+159
-345
lines changed

src/vs/workbench/contrib/notebook/browser/controller/chat/cellChatActions.ts

+2-65
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@ import { ContextKeyExpr } from 'vs/platform/contextkey/common/contextkey';
1515
import { InputFocusedContextKey } from 'vs/platform/contextkey/common/contextkeys';
1616
import { ServicesAccessor } from 'vs/platform/instantiation/common/instantiation';
1717
import { KeybindingWeight } from 'vs/platform/keybinding/common/keybindingsRegistry';
18-
import { CTX_INLINE_CHAT_FOCUSED, CTX_INLINE_CHAT_HAS_PROVIDER, CTX_INLINE_CHAT_INNER_CURSOR_FIRST, CTX_INLINE_CHAT_INNER_CURSOR_LAST, CTX_INLINE_CHAT_LAST_RESPONSE_TYPE, CTX_INLINE_CHAT_RESPONSE_TYPES, InlineChatResponseFeedbackKind, InlineChatResponseTypes } from 'vs/workbench/contrib/inlineChat/common/inlineChat';
19-
import { CTX_NOTEBOOK_CELL_CHAT_FOCUSED, CTX_NOTEBOOK_CHAT_HAS_ACTIVE_REQUEST, CTX_NOTEBOOK_CHAT_OUTER_FOCUS_POSITION, CTX_NOTEBOOK_CHAT_USER_DID_EDIT, MENU_CELL_CHAT_INPUT, MENU_CELL_CHAT_WIDGET, MENU_CELL_CHAT_WIDGET_FEEDBACK, MENU_CELL_CHAT_WIDGET_STATUS } from 'vs/workbench/contrib/notebook/browser/controller/chat/notebookChatContext';
18+
import { CTX_INLINE_CHAT_FOCUSED, CTX_INLINE_CHAT_HAS_PROVIDER, CTX_INLINE_CHAT_INNER_CURSOR_FIRST, CTX_INLINE_CHAT_INNER_CURSOR_LAST, CTX_INLINE_CHAT_RESPONSE_TYPES, InlineChatResponseTypes } from 'vs/workbench/contrib/inlineChat/common/inlineChat';
19+
import { CTX_NOTEBOOK_CELL_CHAT_FOCUSED, CTX_NOTEBOOK_CHAT_HAS_ACTIVE_REQUEST, CTX_NOTEBOOK_CHAT_OUTER_FOCUS_POSITION, CTX_NOTEBOOK_CHAT_USER_DID_EDIT, MENU_CELL_CHAT_INPUT, MENU_CELL_CHAT_WIDGET, MENU_CELL_CHAT_WIDGET_STATUS } from 'vs/workbench/contrib/notebook/browser/controller/chat/notebookChatContext';
2020
import { NotebookChatController } from 'vs/workbench/contrib/notebook/browser/controller/chat/notebookChatController';
2121
import { CELL_TITLE_CELL_GROUP_ID, INotebookActionContext, INotebookCellActionContext, NotebookAction, NotebookCellAction, getEditorFromArgsOrActivePane } from 'vs/workbench/contrib/notebook/browser/controller/coreActions';
2222
import { insertNewCell } from 'vs/workbench/contrib/notebook/browser/controller/insertCellActions';
@@ -299,69 +299,6 @@ registerAction2(class extends NotebookAction {
299299
}
300300
});
301301

302-
registerAction2(class extends NotebookAction {
303-
constructor() {
304-
super({
305-
id: 'notebook.cell.feedbackHelpful',
306-
title: localize('feedback.helpful', 'Helpful'),
307-
icon: Codicon.thumbsup,
308-
menu: {
309-
id: MENU_CELL_CHAT_WIDGET_FEEDBACK,
310-
group: 'inline',
311-
order: 1,
312-
when: CTX_INLINE_CHAT_LAST_RESPONSE_TYPE.notEqualsTo(undefined),
313-
},
314-
f1: false
315-
});
316-
}
317-
318-
async runWithContext(accessor: ServicesAccessor, context: INotebookActionContext) {
319-
NotebookChatController.get(context.notebookEditor)?.feedbackLast(InlineChatResponseFeedbackKind.Helpful);
320-
}
321-
});
322-
323-
registerAction2(class extends NotebookAction {
324-
constructor() {
325-
super({
326-
id: 'notebook.cell.feedbackUnhelpful',
327-
title: localize('feedback.unhelpful', 'Unhelpful'),
328-
icon: Codicon.thumbsdown,
329-
menu: {
330-
id: MENU_CELL_CHAT_WIDGET_FEEDBACK,
331-
group: 'inline',
332-
order: 2,
333-
when: CTX_INLINE_CHAT_LAST_RESPONSE_TYPE.notEqualsTo(undefined),
334-
},
335-
f1: false
336-
});
337-
}
338-
339-
async runWithContext(accessor: ServicesAccessor, context: INotebookActionContext) {
340-
NotebookChatController.get(context.notebookEditor)?.feedbackLast(InlineChatResponseFeedbackKind.Unhelpful);
341-
}
342-
});
343-
344-
registerAction2(class extends NotebookAction {
345-
constructor() {
346-
super({
347-
id: 'notebook.cell.reportIssueForBug',
348-
title: localize('feedback.reportIssueForBug', 'Report Issue'),
349-
icon: Codicon.report,
350-
menu: {
351-
id: MENU_CELL_CHAT_WIDGET_FEEDBACK,
352-
group: 'inline',
353-
order: 3,
354-
when: CTX_INLINE_CHAT_LAST_RESPONSE_TYPE.notEqualsTo(undefined),
355-
},
356-
f1: false
357-
});
358-
}
359-
360-
async runWithContext(accessor: ServicesAccessor, context: INotebookActionContext) {
361-
NotebookChatController.get(context.notebookEditor)?.feedbackLast(InlineChatResponseFeedbackKind.Bug);
362-
}
363-
});
364-
365302
interface IInsertCellWithChatArgs extends INotebookActionContext {
366303
input?: string;
367304
autoSend?: boolean;

0 commit comments

Comments
 (0)