Skip to content
This repository was archived by the owner on Nov 16, 2023. It is now read-only.

Fix #305 Update packages to latest #317

Merged
merged 4 commits into from
Feb 8, 2021

Conversation

samal-rasmussen
Copy link
Contributor

@samal-rasmussen samal-rasmussen commented Feb 4, 2021

Fix #305

Copy link
Collaborator

@peterblazejewicz peterblazejewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! tested locally (win10)
@samal-rasmussen thx!

@peterblazejewicz
Copy link
Collaborator

@samal-rasmussen can you force push changes? I cannot see came CI error locally (build/linter/tests)

@samal-rasmussen
Copy link
Contributor Author

The original travis ci build errors were caused by node-sass, which is deprecated so I went ahead and changed over to the sass package and that seems to have worked for that issue.

But now the build is failing on optional catch bindings in the new versions of the dependencies. This was introduces in node 10 and the travis build is using 8 and 9. So this pr is stranded until someone updates the ci build.

@peterblazejewicz
Copy link
Collaborator

@samal-rasmussen i've changed the versions to be LTSs. Still, you need to take latest (rebase) and push changes with updated .yml, thx!

@samal-rasmussen
Copy link
Contributor Author

Oh that's how Travis works. Had I known it was that easy :)

@peterblazejewicz peterblazejewicz merged commit 3acbef7 into microsoft:master Feb 8, 2021
brittanydrandolph pushed a commit that referenced this pull request Jun 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to TS 4.0
2 participants