-
Notifications
You must be signed in to change notification settings - Fork 440
Add HTMLElement#attachInternals() #818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
582fcb3
to
3f0d0cf
Compare
@sandersn I would appreciate it if you could review this |
Those types have only one implementation which is from Chromium, that's why it's removed from here. |
Thank you for commenting. Implemented in Chromium means that its functionality is available in many web browser products, such as Google Chrome, Microsoft Edge and Opera. Also, it is already implemented in Firefox Nightly. https://hg.mozilla.org/mozilla-central/rev/e6b60876e668 Does the implementation of that method need to be completed in stable version? |
Yes, as Nightly can always drop it without shipping it to stable. |
What about moving definitions in a separated file, so it's up to the user to use it or not (like some ES features) ? |
Currently Definitely Typed is recommended for that purpose. |
I tested support for Firefox and Safari via this glitch app and they're still not available un-flagged: https://web.dev/more-capable-form-controls/#a-working-example We're still happy to wait until that changes, otherwise as @saschanaz says DT is your best option to get it shipped today |
Closing because @saschanaz is one of the code-owners of this repository. |
Fixes microsoft/TypeScript#33218
microsoft/TypeScript#36347 was rejected, so I made this PR.
Rather, please tell me why you removed it.