Skip to content

Add HTMLElement#attachInternals() #818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

naokikimura
Copy link

Fixes microsoft/TypeScript#33218

microsoft/TypeScript#36347 was rejected, so I made this PR.

Rather, please tell me why you removed it.

@naokikimura naokikimura requested a review from sandersn as a code owner January 22, 2020 11:02
@msftclas
Copy link

msftclas commented Jan 22, 2020

CLA assistant check
All CLA requirements met.

@naokikimura
Copy link
Author

@sandersn I would appreciate it if you could review this

@saschanaz
Copy link
Contributor

Rather, please tell me why you removed it.

Those types have only one implementation which is from Chromium, that's why it's removed from here.

@naokikimura
Copy link
Author

naokikimura commented Mar 12, 2020

@saschanaz

Thank you for commenting.

Implemented in Chromium means that its functionality is available in many web browser products, such as Google Chrome, Microsoft Edge and Opera.

Also, it is already implemented in Firefox Nightly. https://hg.mozilla.org/mozilla-central/rev/e6b60876e668

Does the implementation of that method need to be completed in stable version?

@saschanaz
Copy link
Contributor

Does the implementation of that method need to be completed in stable version?

Yes, as Nightly can always drop it without shipping it to stable.

@adriengibrat
Copy link

adriengibrat commented Mar 16, 2020

What about moving definitions in a separated file, so it's up to the user to use it or not (like some ES features) ?

@saschanaz
Copy link
Contributor

Currently Definitely Typed is recommended for that purpose.

@orta
Copy link
Contributor

orta commented Jun 5, 2020

I tested support for Firefox and Safari via this glitch app and they're still not available un-flagged: https://web.dev/more-capable-form-controls/#a-working-example

We're still happy to wait until that changes, otherwise as @saschanaz says DT is your best option to get it shipped today

@orta orta added the Waiting on standards We're waiting on the standards process (or more browser support) label Jun 5, 2020
@saschanaz
Copy link
Contributor

#1141 and #1149 partially restored ElementInternals types thanks to the new Firefox implementation. Others will be restored when further implementation happens.

@github-actions close

@github-actions
Copy link
Contributor

Closing because @saschanaz is one of the code-owners of this repository.

@github-actions github-actions bot closed this Sep 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Waiting on standards We're waiting on the standards process (or more browser support)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ElementInternals, attachInternals from HTML standard
5 participants