Skip to content

Prepare for 4.5b #1160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 5, 2021
Merged

Prepare for 4.5b #1160

merged 4 commits into from
Oct 5, 2021

Conversation

orta
Copy link
Contributor

@orta orta commented Sep 27, 2021

Doesn't look too drastic:

@types/web

New interfaces

  • ElementInternals

Removed interfaces

Modified

  • CSSStyleDeclaration
    • Added: accentColor
  • Document
    • Removed: elementFromPoint, elementsFromPoint - these live on DocumentOrShadowRoot instead
  • HTMLElement
    • Added: attachInternals
  • HTMLSlotElement
    • Added: assign
  • Navigator
    • Added: canShare
    • Removed: pointerEnabled - removed from spec in 2014
  • ReadableStream
  • Text
    • Removed: assignedSlot - This might be something we backtrack during the beta, will be easy to re-add if we want. d42f963#r57102539

Non-value types

  • MediaTrackConstraintSet
    • Added: autoGainControl, noiseSuppression
  • MediaTrackSettings
    • Added: autoGainControl, noiseSuppression
  • MediaTrackSupportedConstraints
    • Added: autoGainControl, noiseSuppression
  • DocumentOrShadowRoot
    • Added: elementFromPoint, elementsFromPoint

index.iterable.d.ts

No changes

@github-actions
Copy link
Contributor

Thanks for the PR!

This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged.

@orta
Copy link
Contributor Author

orta commented Sep 27, 2021

It looks like the migration process doesn't take into account that we have to change the abortcontroller -

function postProcessDTSFiles(pkg, packagePath) {
iterateThroughFiles((content) => {
return content.replace(
"abort(): AbortSignal;",
"// abort(): AbortSignal; - To be re-added in the future"
);
});
which means anyone without context is going to keep breaking the migration into TS

@orta
Copy link
Contributor Author

orta commented Oct 5, 2021

I've added a button to generate a PR to TypeScript re-using @saschanaz's BCD PR work, as the rumor mill is that I got it wrong microsoft/TypeScript#46080 (comment) and that's a good cause to automate

Might have to do a few pushes to main to get it right

@orta orta merged commit 8844acc into main Oct 5, 2021
@orta
Copy link
Contributor Author

orta commented Oct 5, 2021

There we go microsoft/TypeScript#46222

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant