Skip to content

Update to mupdf@1.26.0-rc1 #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Conversation

SmarterFuture
Copy link

This updates mupdf-sys bindings to the newest release candidate (1.26.0-rc1) as it now contains bindings to functions such as pdf_set_annot_rich_contents

@SmarterFuture SmarterFuture changed the title updated to mupdf@1.26.0-rc1 Update to mupdf@1.26.0-rc1 Apr 22, 2025
@SmarterFuture
Copy link
Author

Unfortunately I do not have any experience with Address Sanitizer and currently do not have access to windows so I cannot resolve other failed tests

@itsjunetime
Copy link
Collaborator

I haven't been able to figure out the windows issues in my own pr either (#121), but you can debug asan stuff on your own machine with ASAN_OPTIONS=report_objects=1 RUSTFLAGS="-Zsanitizer=leak" cargo +nightly test -Zbuild-std --target "$(rustc -vV | grep host | cut -d " " -f2)" --features serde (I wish it had an easier invocation too)

@ginnyTheCat
Copy link
Collaborator

I bisected the asan failure and it was apparently introducted in ArtifexSoftware/mupdf@1d240cc.

@ginnyTheCat
Copy link
Collaborator

Found it. We call Buffer::into_inner here to keep the Buffer, mupdf however also keeps the buffer in case no error occurs, causing the Buffer to be held twice and therefore leaking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants