Skip to content

Fix overlapping VR support statements for Firefox #26595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 8, 2025

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Apr 22, 2025

Summary

Fixes several overlapping support statements for Firefox related to VR features.

Test results and supporting details

Before, there were distinct statements for

  1. Windows support (added 55, removed 98), and
  2. macOS support (added 64, removed 98).

After, there are cumulative statements for

  1. Windows support (added 55, removed 64), and
  2. macOS and Windows support (added 64, removed 98).

Related issues

Extracted from #26544.

Part of #26543.

@github-actions github-actions bot added data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API size:l [PR only] 101-1000 LoC changed labels Apr 22, 2025
caugner added a commit that referenced this pull request Apr 22, 2025
@caugner caugner marked this pull request as draft April 22, 2025 11:26
caugner added a commit that referenced this pull request Apr 22, 2025
@caugner caugner requested review from Elchi3 and queengooborg April 22, 2025 11:49
@caugner caugner changed the title Fix overlapping VR support ranges Fix overlapping VR support statements for Firefox Apr 22, 2025
@caugner caugner marked this pull request as ready for review April 22, 2025 11:52
@caugner caugner force-pushed the 26543-fix-overlapping-vr-ranges branch from bd81b57 to 38023db Compare April 22, 2025 12:15
Copy link
Contributor

Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs).

Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems okay to me. I just hope we can remove this data entirely at some point. All browsers removed it except Firefox which put it behind a flag. So, it is quite irrelevant already.
https://bugzilla.mozilla.org/show_bug.cgi?id=1636311 has no activity unfortunately.

@Elchi3 Elchi3 merged commit 1b6eb6c into main May 8, 2025
11 checks passed
@Elchi3 Elchi3 deleted the 26543-fix-overlapping-vr-ranges branch May 8, 2025 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API size:l [PR only] 101-1000 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants