Implement Stringable interface on Enum #156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #156 +/- ##
=========================================
Coverage 99.81% 99.81%
Complexity 227 227
=========================================
Files 4 4
Lines 555 555
=========================================
Hits 554 554
Misses 1 1
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
|
@jdecool thank you for this PR and improvement. I think it's a good idea to make this interface explicit and available for all versions. Although I don't really like to add a dependency for this simple case. A stub with class map loading from composer same as https://github.com/symfony/polyfill/blob/main/src/Php80/Resources/stubs/Stringable.php should be enough. |
|
👍 LGTM. I’m going to update this PR |
|
@marc-mabe The PR has just been updated |
|
I have moved the classmap setting from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enum class has a __toString, so it would be great to implements the new Stringable interface.
As the interface is not available for php < 8, I've had the symfony/polyfill-php-80.
I've removed psalm
totallyTypedattribute as it's now deprecated.