Generics + better doc types PHPStan/psalm #138
Conversation
marc-mabe
force-pushed
the
doc-generics
branch
from
35d7c82 to
b1ff1ac
Compare
marc-mabe
force-pushed
the
doc-generics
branch
4 times, most recently
from
1c8f566 to
5914b16
Compare
|
@prolic Hi - please could you take a look on this and share your opinions? |
|
Sorry, super busy at the moment, but I try the next few days.
Sascha-Oliver Prolic
Am Sa., 11. Jan. 2020 um 09:45 Uhr schrieb Marc Bennewitz <
notifications@github.com>:
… @prolic <https://github.com/prolic> Hi - please could you take a look on
this and share your opinions?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#138?email_source=notifications&email_token=AADAJPALBYIFWLTIFYQLMRLQ5G5NXA5CNFSM4J6AAHSKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIWBGNQ#issuecomment-573313846>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADAJPH4I52HEBFZOSXTKBDQ5G5NXANCNFSM4J6AAHSA>
.
|
|
All goodI'm super happy to get your help from time to timeAm 16.01.2020 02:07 schrieb Sascha-Oliver Prolic <notifications@github.com>:Sorry, super busy at the moment, but I try the next few days.
Sascha-Oliver Prolic
Am Sa., 11. Jan. 2020 um 09:45 Uhr schrieb Marc Bennewitz <
notifications@github.com>:
@prolic <https://github.com/prolic> Hi - please could you take a look on
this and share your opinions?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#138?email_source=notifications&email_token=AADAJPALBYIFWLTIFYQLMRLQ5G5NXA5CNFSM4J6AAHSKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIWBGNQ#issuecomment-573313846>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADAJPH4I52HEBFZOSXTKBDQ5G5NXANCNFSM4J6AAHSA>
.
—You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
Thanks for reviewing @prolic 👍 |
|
There is a plug-in for phpstorm, but when I tried I couldn't get the
expected results.
…On Wed, Feb 12, 2020, 04:55 Marc Bennewitz ***@***.***> wrote:
Thanks for reviewing @prolic <https://github.com/prolic> 👍
I would like to get your opinion about IDE support as currently such
Syntax is not natively supported by any of the IDEs I know. Means PHPStan
gets better results but it reduces developer experience like autocompletion.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#138?email_source=notifications&email_token=AADAJPDOKIDZDAVVP7KN7QLRCOTQTA5CNFSM4J6AAHSKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELPZKDI#issuecomment-585078029>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADAJPFFQTOHDZKTZYNYV5LRCOTQTANCNFSM4J6AAHSA>
.
|
|
@marc-mabe What's the status here? |
|
The problem is this this breaks IDEs. I was hoping that at least some IDEs start to support it but it didn't until now. As a workaround all the annotations needs to be prefixed. Additionally I want to test this with psalm as well but didn't have time. PS: my private time reduced drastically with the crises ... @prolic Would you like to be added as a collaborator? |
|
@marc-mabe I maintain already at least 15 open source projects, one more doesn't make a difference at this point, lol. Sure, go ahead and add me. |
|
@prolic I have added you. I have no idea where you get the time and energy to work on so many OS projects. You are my hero ;) |
|
Encountered a problem on how PHPStan interprets psalm type |
marc-mabe
changed the title
EnumSetandEnumMap