Updated for PHP 8. Tested most with Unit Tests. #51

CobraSphere-IB · 2021-04-03T22:12:58Z

Updated for PHP 8. Tested most with Unit Tests.
Recommend full testing by maintainer.

On branch updated-for-php8
Changes to be committed:
modified: .gitignore
new file: .phpunit.result.cache
modified: composer.json
modified: phpunit.xml
new file: phpunit.xml.bak
modified: tests/BatchTest.php
modified: tests/CampaignsTest.php
modified: tests/SegmentsTest.php
modified: tests/SubscribersTest.php
modified: tests/bootstrap.php

Recommend full testing my maintainer. On branch updated-for-php8 Changes to be committed: modified: .gitignore new file: .phpunit.result.cache modified: composer.json modified: phpunit.xml new file: phpunit.xml.bak modified: tests/BatchTest.php modified: tests/CampaignsTest.php modified: tests/SegmentsTest.php modified: tests/SubscribersTest.php modified: tests/bootstrap.php

arokettu · 2021-05-28T17:47:55Z

.phpunit.result.cache

@@ -0,0 +1 @@
+C:37:"PHPUnit\Runner\DefaultTestResultCache":4172:{a:2:{s:7:"defects";a:29:{s:41:"MailerLiteApi\Tests\BatchTest::send_batch";i:4;s:50:"MailerLiteApi\Tests\CampaignsTest::create_campaign";i:4;s:48:"MailerLiteApi\Tests\CampaignsTest::get_campaigns";i:3;s:49:"MailerLiteApi\Tests\FieldsTest::check_fields_data";i:4;s:44:"MailerLiteApi\Tests\FieldsTest::create_field";i:4;s:49:"MailerLiteApi\Tests\GroupsTest::check_groups_data";i:4;s:55:"MailerLiteApi\Tests\GroupsTest::check_single_group_data";i:4;s:60:"MailerLiteApi\Tests\GroupsTest::check_group_subscribers_data";i:4;s:73:"MailerLiteApi\Tests\GroupsTest::check_group_subscribers_unsubscribed_data";i:4;s:60:"MailerLiteApi\Tests\GroupsTest::check_groups_data_with_limit";i:4;s:71:"MailerLiteApi\Tests\GroupsTest::check_group_subscribers_data_with_limit";i:4;s:50:"MailerLiteApi\Tests\GroupsTest::check_groups_count";i:4;s:44:"MailerLiteApi\Tests\GroupsTest::create_group";i:4;s:44:"MailerLiteApi\Tests\GroupsTest::update_group";i:4;s:57:"MailerLiteApi\Tests\GroupsTest::add_and_remove_subscriber";i:4;s:50:"MailerLiteApi\Tests\GroupsTest::import_subscribers";i:4;s:46:"MailerLiteApi\Tests\RestClientTest::get_method";i:4;s:61:"MailerLiteApi\Tests\RestClientTest::mailerlite_sdk_user_agent";i:4;s:47:"MailerLiteApi\Tests\RestClientTest::post_method";i:4;s:46:"MailerLiteApi\Tests\RestClientTest::put_method";i:4;s:49:"MailerLiteApi\Tests\RestClientTest::delete_method";i:4;s:46:"MailerLiteApi\Tests\SegmentsTest::get_segments";i:3;s:40:"MailerLiteApi\Tests\StatsTest::get_stats";i:3;s:52:"MailerLiteApi\Tests\StatsTest::get_stats_in_the_past";i:4;s:60:"MailerLiteApi\Tests\SubscribersTest::get_subscriber_by_email";i:4;s:57:"MailerLiteApi\Tests\SubscribersTest::get_subscriber_by_id";i:4;s:54:"MailerLiteApi\Tests\SubscribersTest::update_subscriber";i:4;s:60:"MailerLiteApi\Tests\SubscribersTest::search_for_a_subscriber";i:3;s:7:"Warning";i:6;}s:5:"times";a:34:{s:73:"MailerLiteApi\Tests\BatchTest::at_least_one_request_is_provided_exception";d:0.012;s:76:"MailerLiteApi\Tests\BatchTest::provided_requests_must_be_batch_request_class";d:0.002;s:41:"MailerLiteApi\Tests\BatchTest::send_batch";d:2.054;s:50:"MailerLiteApi\Tests\CampaignsTest::create_campaign";d:0.472;s:48:"MailerLiteApi\Tests\CampaignsTest::get_campaigns";d:0.415;s:49:"MailerLiteApi\Tests\FieldsTest::check_fields_data";d:0.661;s:44:"MailerLiteApi\Tests\FieldsTest::create_field";d:0.499;s:49:"MailerLiteApi\Tests\GroupsTest::check_groups_data";d:2.65;s:55:"MailerLiteApi\Tests\GroupsTest::check_single_group_data";d:2.677;s:60:"MailerLiteApi\Tests\GroupsTest::check_group_subscribers_data";d:2.75;s:73:"MailerLiteApi\Tests\GroupsTest::check_group_subscribers_unsubscribed_data";d:2.447;s:60:"MailerLiteApi\Tests\GroupsTest::check_groups_data_with_limit";d:4.036;s:71:"MailerLiteApi\Tests\GroupsTest::check_group_subscribers_data_with_limit";d:2.214;s:50:"MailerLiteApi\Tests\GroupsTest::check_groups_count";d:2.395;s:44:"MailerLiteApi\Tests\GroupsTest::create_group";d:2.437;s:44:"MailerLiteApi\Tests\GroupsTest::update_group";d:2.472;s:57:"MailerLiteApi\Tests\GroupsTest::add_and_remove_subscriber";d:10.493;s:50:"MailerLiteApi\Tests\GroupsTest::import_subscribers";d:3.695;s:51:"MailerLiteApi\Tests\MailerLiteTest::invalid_api_key";d:0;s:46:"MailerLiteApi\Tests\RestClientTest::get_method";d:0.506;s:61:"MailerLiteApi\Tests\RestClientTest::mailerlite_sdk_user_agent";d:0.464;s:47:"MailerLiteApi\Tests\RestClientTest::post_method";d:0.479;s:46:"MailerLiteApi\Tests\RestClientTest::put_method";d:0.475;s:49:"MailerLiteApi\Tests\RestClientTest::delete_method";d:0.433;s:57:"MailerLiteApi\Tests\RestClientTest::error_internal_server";d:0.429;s:45:"MailerLiteApi\Tests\RestClientTest::error_400";d:0.468;s:46:"MailerLiteApi\Tests\SegmentsTest::get_segments";d:0.242;s:40:"MailerLiteApi\Tests\StatsTest::get_stats";d:0.248;s:52:"MailerLiteApi\Tests\StatsTest::get_stats_in_the_past";d:0.197;s:60:"MailerLiteApi\Tests\SubscribersTest::get_subscriber_by_email";d:0.796;s:57:"MailerLiteApi\Tests\SubscribersTest::get_subscriber_by_id";d:0.86;s:54:"MailerLiteApi\Tests\SubscribersTest::update_subscriber";d:0.891;s:60:"MailerLiteApi\Tests\SubscribersTest::search_for_a_subscriber";d:1.064;s:7:"Warning";d:0.001;}}}


This file should be ignored

arokettu · 2021-05-28T17:48:30Z

composer.json

@@ -6,7 +6,7 @@
    "keywords": ["mailerlite", "sdk", "email", "marketing"],
    "type": "library",
    "require": {
-        "php" : "^7.1",
+        "php" : "^8.0",


I doubt they will accept this version bump. It should be "^7.1 || ^8.0"

MarGul · 2021-07-30T12:21:27Z

Do we have any updates regarding this?

On branch updated-for-php8 Changes to be committed: modified: .gitignore modified: composer.json

Changes to be committed: modified: .gitignore

arokettu · 2021-07-30T21:12:50Z

.gitignore

+_notes
+.phpunit.result.cache


The file itself should be deleted from the repo too

Changes to be committed: deleted: .phpunit.result.cache

johnkelesidis · 2021-08-02T10:31:27Z

composer.json

@@ -6,7 +6,7 @@
    "keywords": ["mailerlite", "sdk", "email", "marketing"],
    "type": "library",
    "require": {
-        "php" : "^7.1",
+        "php" : "7.1 || ^8.0",


I agree with @arokettu , this should be ^7.1 || ^8.0

Changes to be committed: modified: composer.json

nklmilojevic · 2021-08-09T15:49:01Z

Hey all! Thank you for contributing. We will try to test and merge the changes this week and let you know. 🙌🏻

ilidan85 approved these changes May 20, 2021

View reviewed changes

arokettu reviewed May 28, 2021

View reviewed changes

MarGul mentioned this pull request Jul 30, 2021

Support php 8 #47

Closed

CobraSphere-IB added 2 commits July 30, 2021 12:59

Updated to support PHP 7.1+ or PHP 8.0

5da86f1

On branch updated-for-php8 Changes to be committed: modified: .gitignore modified: composer.json

On branch updated-for-php8

b859fe8

Changes to be committed: modified: .gitignore

arokettu reviewed Jul 30, 2021

View reviewed changes

.gitignore

_notes

.phpunit.result.cache

Copy link

arokettu Jul 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file itself should be deleted from the repo too

On branch updated-for-php8

3233121

Changes to be committed: deleted: .phpunit.result.cache

JuliusB approved these changes Aug 2, 2021

View reviewed changes

johnkelesidis requested changes Aug 2, 2021

View reviewed changes

On branch updated-for-php8

446adb1

Changes to be committed: modified: composer.json

johnkelesidis approved these changes Aug 11, 2021

View reviewed changes

johnkelesidis merged commit 9fb6b8a into mailerlite:main Aug 11, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updated for PHP 8. Tested most with Unit Tests. #51

Updated for PHP 8. Tested most with Unit Tests. #51

CobraSphere-IB commented Apr 3, 2021 •

edited

Loading

arokettu May 28, 2021

arokettu May 28, 2021

MarGul commented Jul 30, 2021

arokettu Jul 30, 2021

johnkelesidis Aug 2, 2021

nklmilojevic commented Aug 9, 2021

		@@ -0,0 +1 @@
		C:37:"PHPUnit\Runner\DefaultTestResultCache":4172:{a:2:{s:7:"defects";a:29:{s:41:"MailerLiteApi\Tests\BatchTest::send_batch";i:4;s:50:"MailerLiteApi\Tests\CampaignsTest::create_campaign";i:4;s:48:"MailerLiteApi\Tests\CampaignsTest::get_campaigns";i:3;s:49:"MailerLiteApi\Tests\FieldsTest::check_fields_data";i:4;s:44:"MailerLiteApi\Tests\FieldsTest::create_field";i:4;s:49:"MailerLiteApi\Tests\GroupsTest::check_groups_data";i:4;s:55:"MailerLiteApi\Tests\GroupsTest::check_single_group_data";i:4;s:60:"MailerLiteApi\Tests\GroupsTest::check_group_subscribers_data";i:4;s:73:"MailerLiteApi\Tests\GroupsTest::check_group_subscribers_unsubscribed_data";i:4;s:60:"MailerLiteApi\Tests\GroupsTest::check_groups_data_with_limit";i:4;s:71:"MailerLiteApi\Tests\GroupsTest::check_group_subscribers_data_with_limit";i:4;s:50:"MailerLiteApi\Tests\GroupsTest::check_groups_count";i:4;s:44:"MailerLiteApi\Tests\GroupsTest::create_group";i:4;s:44:"MailerLiteApi\Tests\GroupsTest::update_group";i:4;s:57:"MailerLiteApi\Tests\GroupsTest::add_and_remove_subscriber";i:4;s:50:"MailerLiteApi\Tests\GroupsTest::import_subscribers";i:4;s:46:"MailerLiteApi\Tests\RestClientTest::get_method";i:4;s:61:"MailerLiteApi\Tests\RestClientTest::mailerlite_sdk_user_agent";i:4;s:47:"MailerLiteApi\Tests\RestClientTest::post_method";i:4;s:46:"MailerLiteApi\Tests\RestClientTest::put_method";i:4;s:49:"MailerLiteApi\Tests\RestClientTest::delete_method";i:4;s:46:"MailerLiteApi\Tests\SegmentsTest::get_segments";i:3;s:40:"MailerLiteApi\Tests\StatsTest::get_stats";i:3;s:52:"MailerLiteApi\Tests\StatsTest::get_stats_in_the_past";i:4;s:60:"MailerLiteApi\Tests\SubscribersTest::get_subscriber_by_email";i:4;s:57:"MailerLiteApi\Tests\SubscribersTest::get_subscriber_by_id";i:4;s:54:"MailerLiteApi\Tests\SubscribersTest::update_subscriber";i:4;s:60:"MailerLiteApi\Tests\SubscribersTest::search_for_a_subscriber";i:3;s:7:"Warning";i:6;}s:5:"times";a:34:{s:73:"MailerLiteApi\Tests\BatchTest::at_least_one_request_is_provided_exception";d:0.012;s:76:"MailerLiteApi\Tests\BatchTest::provided_requests_must_be_batch_request_class";d:0.002;s:41:"MailerLiteApi\Tests\BatchTest::send_batch";d:2.054;s:50:"MailerLiteApi\Tests\CampaignsTest::create_campaign";d:0.472;s:48:"MailerLiteApi\Tests\CampaignsTest::get_campaigns";d:0.415;s:49:"MailerLiteApi\Tests\FieldsTest::check_fields_data";d:0.661;s:44:"MailerLiteApi\Tests\FieldsTest::create_field";d:0.499;s:49:"MailerLiteApi\Tests\GroupsTest::check_groups_data";d:2.65;s:55:"MailerLiteApi\Tests\GroupsTest::check_single_group_data";d:2.677;s:60:"MailerLiteApi\Tests\GroupsTest::check_group_subscribers_data";d:2.75;s:73:"MailerLiteApi\Tests\GroupsTest::check_group_subscribers_unsubscribed_data";d:2.447;s:60:"MailerLiteApi\Tests\GroupsTest::check_groups_data_with_limit";d:4.036;s:71:"MailerLiteApi\Tests\GroupsTest::check_group_subscribers_data_with_limit";d:2.214;s:50:"MailerLiteApi\Tests\GroupsTest::check_groups_count";d:2.395;s:44:"MailerLiteApi\Tests\GroupsTest::create_group";d:2.437;s:44:"MailerLiteApi\Tests\GroupsTest::update_group";d:2.472;s:57:"MailerLiteApi\Tests\GroupsTest::add_and_remove_subscriber";d:10.493;s:50:"MailerLiteApi\Tests\GroupsTest::import_subscribers";d:3.695;s:51:"MailerLiteApi\Tests\MailerLiteTest::invalid_api_key";d:0;s:46:"MailerLiteApi\Tests\RestClientTest::get_method";d:0.506;s:61:"MailerLiteApi\Tests\RestClientTest::mailerlite_sdk_user_agent";d:0.464;s:47:"MailerLiteApi\Tests\RestClientTest::post_method";d:0.479;s:46:"MailerLiteApi\Tests\RestClientTest::put_method";d:0.475;s:49:"MailerLiteApi\Tests\RestClientTest::delete_method";d:0.433;s:57:"MailerLiteApi\Tests\RestClientTest::error_internal_server";d:0.429;s:45:"MailerLiteApi\Tests\RestClientTest::error_400";d:0.468;s:46:"MailerLiteApi\Tests\SegmentsTest::get_segments";d:0.242;s:40:"MailerLiteApi\Tests\StatsTest::get_stats";d:0.248;s:52:"MailerLiteApi\Tests\StatsTest::get_stats_in_the_past";d:0.197;s:60:"MailerLiteApi\Tests\SubscribersTest::get_subscriber_by_email";d:0.796;s:57:"MailerLiteApi\Tests\SubscribersTest::get_subscriber_by_id";d:0.86;s:54:"MailerLiteApi\Tests\SubscribersTest::update_subscriber";d:0.891;s:60:"MailerLiteApi\Tests\SubscribersTest::search_for_a_subscriber";d:1.064;s:7:"Warning";d:0.001;}}}

Updated for PHP 8. Tested most with Unit Tests. #51

Updated for PHP 8. Tested most with Unit Tests. #51

Conversation

CobraSphere-IB commented Apr 3, 2021 • edited Loading

arokettu May 28, 2021

Choose a reason for hiding this comment

arokettu May 28, 2021

Choose a reason for hiding this comment

MarGul commented Jul 30, 2021

arokettu Jul 30, 2021

Choose a reason for hiding this comment

johnkelesidis Aug 2, 2021

Choose a reason for hiding this comment

nklmilojevic commented Aug 9, 2021

CobraSphere-IB commented Apr 3, 2021 •

edited

Loading