Skip to content

fix Display tax percent in current locale number format #32272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

fix Display tax percent in current locale number format #32272

wants to merge 4 commits into from

Conversation

engcom-Charlie
Copy link
Contributor

@engcom-Charlie engcom-Charlie commented Feb 24, 2021 •
edited
Loading

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Display tax percent in current locale number format #18724

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@engcom-Charlie
Copy link
Contributor Author

@magento run all tests

@engcom-Charlie
Copy link
Contributor Author

@magento run all tests

@engcom-Charlie engcom-Charlie changed the title [WIP] fix percent amount converting fix percent amount converting Feb 25, 2021
@magento magento deleted a comment from m2-assistant bot Feb 25, 2021
@engcom-Charlie
Copy link
Contributor Author

@magento run all tests

@engcom-Charlie engcom-Charlie changed the title fix percent amount converting fix Display tax percent in current locale number format Feb 25, 2021
@engcom-Charlie engcom-Charlie added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Feb 25, 2021
@engcom-Charlie
Copy link
Contributor Author

@magento run all tests

@danielrussob
Copy link

@magento give me test instance

@magento-deployment-service
Copy link

Hi @danielrussob. Thank you for your request. I'm working on Magento instance for you.

@danielrussob
Copy link

@magento give me 2.4-develop instance

@magento-deployment-service
Copy link

Hi @danielrussob. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service
Copy link

Hi @danielrussob, here is your Magento Instance: https://55e06e179063e9445d9ea209e067d54a.instances.magento-community.engineering
Admin access: https://55e06e179063e9445d9ea209e067d54a.instances.magento-community.engineering/admin_4cf8
Login: 93fdacc4
Password: f40c5211b308

@magento-deployment-service
Copy link

Hi @danielrussob, here is your Magento Instance: https://55e06e179063e9445d9ea209e067d54a-2-4-develop.instances.magento-community.engineering
Admin access: https://55e06e179063e9445d9ea209e067d54a-2-4-develop.instances.magento-community.engineering/admin_d331
Login: 83cf0dfb
Password: 02c6dd464bc6

aleron75
aleron75 reviewed May 11, 2021
View reviewed changes
app/code/Magento/Checkout/view/frontend/web/js/view/summary/abstract-total.js
getFormattedPercent: function (amount) {
var format = Object.assign({}, quote.getPriceFormat());

format.requiredPrecision = this.countPrecision(amount, format.decimalSymbol);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @engcom-Charlie,
I'm curious about why did you have to calculate the required precision?

I see that the priceUtils.formatPrice() function already has a fallback value (precision of 2 digits) in case format.requiredPrecision is not defined.

Thank you

@danielrussob danielrussob self-requested a review May 11, 2021 17:24
@danielrussob
Copy link

Hello @daniel-ifrim ,
thank you for your contribution

I'm not able to see a fix on your PR's instance, as you can see in the screenshot

image

@ishakhsuvarov
Copy link
Contributor

Looks like issue has not been resolved and code review questions were not addressed.

Closing for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleron75 aleron75 aleron75 left review comments

@danielrussob danielrussob Awaiting requested review from danielrussob

Assignees

@aleron75 aleron75

@danielrussob danielrussob

Labels
Area: Frontend Component: Catalog Component: Checkout Component: Tax Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Release Line: 2.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Display tax percent in current locale number format
5 participants
@engcom-Charlie @danielrussob @ishakhsuvarov @aleron75 @magento-engcom-team