Skip to content

[NVPTX] Fix NVPTXAA_before_BasicAA Test #138992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 7, 2025

Conversation

Chengjunp
Copy link
Contributor

@Chengjunp Chengjunp commented May 7, 2025

Fix the failed test in the PR by moving the test to CodeGen/NVPTX.

@llvmbot
Copy link
Member

llvmbot commented May 7, 2025

@llvm/pr-subscribers-backend-nvptx

@llvm/pr-subscribers-llvm-analysis

Author: Chengjun (Chengjunp)

Changes

Fix the failed test in the PR by adding the REQUIRES for nvptx-registered-target.


Full diff: https://github.com/llvm/llvm-project/pull/138992.diff

1 Files Affected:

  • (modified) llvm/test/Analysis/NVPTXAA/NVPTXAA_before_BasicAA.ll (+1-1)
diff --git a/llvm/test/Analysis/NVPTXAA/NVPTXAA_before_BasicAA.ll b/llvm/test/Analysis/NVPTXAA/NVPTXAA_before_BasicAA.ll
index 0d16b344e9f66..d43ab29a14cef 100644
--- a/llvm/test/Analysis/NVPTXAA/NVPTXAA_before_BasicAA.ll
+++ b/llvm/test/Analysis/NVPTXAA/NVPTXAA_before_BasicAA.ll
@@ -1,4 +1,4 @@
-; REQUIRES: asserts
+; REQUIRES: asserts, nvptx-registered-target
 ; RUN: opt -aa-pipeline=default -passes='require<aa>' -debug-pass-manager -disable-output -S < %s 2>&1 | FileCheck %s
 ; RUN: llc --debug-only='aa' -o /dev/null %s 2>&1 | FileCheck %s -check-prefix=LEGACY
 

@AlexMaclean
Copy link
Member

I don't see any other target-specific analyses in llvm/test/Analysis. Maybe we should move this test to llvm/test/CodeGen/NVPTX?

Copy link
Member

@AlexMaclean AlexMaclean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Chengjunp Chengjunp merged commit 934cfa7 into llvm:main May 7, 2025
6 of 9 checks passed
petrhosek pushed a commit to petrhosek/llvm-project that referenced this pull request May 8, 2025
Fix the failed test in the
[PR](llvm#125965) by moving the
test to CodeGen/NVPTX.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants