Skip to content

[llvm-size] Add test for invalid conversion spec on error #128941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

vitalybuka
Copy link
Collaborator

Follow up to #128447.

Created using spr 1.3.4
@llvmbot
Copy link
Member

llvmbot commented Feb 26, 2025

@llvm/pr-subscribers-llvm-binary-utilities

Author: Vitaly Buka (vitalybuka)

Changes

Follow up to #128447.


Full diff: https://github.com/llvm/llvm-project/pull/128941.diff

1 Files Affected:

  • (modified) llvm/test/tools/llvm-size/radix.test (+7-6)
diff --git a/llvm/test/tools/llvm-size/radix.test b/llvm/test/tools/llvm-size/radix.test
index 31956ff12895f..77d7b24b3f588 100644
--- a/llvm/test/tools/llvm-size/radix.test
+++ b/llvm/test/tools/llvm-size/radix.test
@@ -109,19 +109,20 @@
 
 ## Case 9: Bad values.
 # RUN: not llvm-size %t1.o --radix=0 2>&1 \
-# RUN:   | FileCheck %s --check-prefix=BAD-VAL -DNUM=0
+# RUN:   | FileCheck %s --check-prefix=BAD-VAL -DFILE1=%t1.o -DNUM=0
 # RUN: not llvm-size %t1.o --radix=1 2>&1 \
-# RUN:   | FileCheck %s --check-prefix=BAD-VAL -DNUM=1
+# RUN:   | FileCheck %s --check-prefix=BAD-VAL -DFILE1=%t1.o -DNUM=1
 # RUN: not llvm-size %t1.o --radix=2 2>&1 \
-# RUN:   | FileCheck %s --check-prefix=BAD-VAL -DNUM=2
+# RUN:   | FileCheck %s --check-prefix=BAD-VAL -DFILE1=%t1.o -DNUM=2
 # RUN: not llvm-size %t1.o --radix=32 2>&1 \
-# RUN:   | FileCheck %s --check-prefix=BAD-VAL -DNUM=32
+# RUN:   | FileCheck %s --check-prefix=BAD-VAL -DFILE1=%t1.o -DNUM=32
 # RUN: not llvm-size %t1.o --radix=-1 2>&1 \
-# RUN:   | FileCheck %s --check-prefix=BAD-VAL -DNUM=-1
+# RUN:   | FileCheck %s --check-prefix=BAD-VAL -DFILE1=%t1.o -DNUM=-1
 # RUN: not llvm-size %t1.o --radix=bad 2>&1 \
-# RUN:   | FileCheck %s --check-prefix=BAD-VAL -DNUM=bad
+# RUN:   | FileCheck %s --check-prefix=BAD-VAL -DFILE1=%t1.o -DNUM=bad
 
 # BAD-VAL: {{.*}}llvm-size{{.*}}: error: --radix value should be one of: 8, 10, 16
+# BAD-VAL:       1       2       4       7       7 [[FILE1]]
 
 --- !ELF
 FileHeader:

Copy link
Collaborator

@jh7370 jh7370 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@vitalybuka vitalybuka merged commit b8337bc into main Feb 28, 2025
13 checks passed
@vitalybuka vitalybuka deleted the users/vitalybuka/spr/llvm-size-add-test-for-invalid-conversion-spec-on-error branch February 28, 2025 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants