[MLIR][ROCDL] Add dynamically legal ops to LowerGpuOpsToROCDLOpsPass

[nirvedhmeshram]

Similar to #108266
After #102971
It is legal to generate LLVM::ExpOp and LLVM::LogOp if the type is is a float narrower than f64

[llvmbot]

@llvm/pr-subscribers-mlir

@llvm/pr-subscribers-mlir-gpu

Author: Nirvedh Meshram (nirvedhmeshram)

Changes

Similar to #108266
After #102971
It is legal to generate LLVM::ExpOp and LLVM::LogOp if the type is f32

---

Full diff: https://github.com/llvm/llvm-project/pull/108302.diff

1 Files Affected:

• (modified) mlir/lib/Conversion/GPUToROCDL/LowerGpuOpsToROCDLOps.cpp (+8-1)

diff --git a/mlir/lib/Conversion/GPUToROCDL/LowerGpuOpsToROCDLOps.cpp b/mlir/lib/Conversion/GPUToROCDL/LowerGpuOpsToROCDLOps.cpp
index 29926719129dc5..1265f3f48a418e 100644
--- a/mlir/lib/Conversion/GPUToROCDL/LowerGpuOpsToROCDLOps.cpp
+++ b/mlir/lib/Conversion/GPUToROCDL/LowerGpuOpsToROCDLOps.cpp
@@ -332,7 +332,14 @@ void mlir::configureGpuToROCDLConversionLegality(ConversionTarget &target) {
   target.addIllegalOp<LLVM::CosOp, LLVM::ExpOp, LLVM::Exp2Op, LLVM::FCeilOp,
                       LLVM::FFloorOp, LLVM::FRemOp, LLVM::LogOp, LLVM::Log10Op,
                       LLVM::Log2Op, LLVM::PowOp, LLVM::SinOp>();
-
+  // These ops are legal for f32 type.
+  target.addDynamicallyLegalOp<LLVM::ExpOp, LLVM::LogOp>(
+      [](mlir::Operation *op) {
+        return llvm::any_of(op->getOperandTypes(), [](Type type) {
+          return llvm::isa<FloatType>(type) &&
+                 type.getIntOrFloatBitWidth() == 32;
+        });
+      });
   // TODO: Remove once we support replacing non-root ops.
   target.addLegalOp<gpu::YieldOp, gpu::GPUModuleOp>();
 }

[joker-eph]

Can you please add a test?

[nirvedhmeshram]

Can you please add a test?

done!

[kuhar]

LGTM

[llvm-ci]

LLVM Buildbot has detected a new failure on builder mlir-rocm-mi200 running on mi200-buildbot while building mlir,utils at step 2 "checkout".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/177/builds/4875

Here is the relevant piece of the build log for the reference

Step 2 (checkout) failure: update (failure)
git version 2.25.1
fatal: unable to access 'https://github.com/llvm/llvm-project.git/': Could not resolve host: github.com
fatal: unable to access 'https://github.com/llvm/llvm-project.git/': Could not resolve host: github.com

[pcf000]

Transient failure, builds 4876 and 4877 had no problems.