Skip to content

clang-tidy: Add ctime, ctime_r, localtime, and localtime_r to clang-tidy #107445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
zimirza opened this issue Sep 5, 2024 · 1 comment · May be fixed by #110366
Open

clang-tidy: Add ctime, ctime_r, localtime, and localtime_r to clang-tidy #107445

zimirza opened this issue Sep 5, 2024 · 1 comment · May be fixed by #110366
Labels
clang-tidy enhancement Improving things as opposed to bug fixing, e.g. new or missing feature

Comments

@zimirza
Copy link
Contributor

zimirza commented Sep 5, 2024

#86567 is an issue for implementing ctime and the pull request for this implementation is #107285. It would be good to add ctime to clang-tidy.

This issue should add ctime and ctime_r to getReplacementFor function in UnsafeFunctionsCheck.cpp.
zimirza added a commit to zimirza/llvm-project that referenced this issue Sep 5, 2024
@zimirza
[libc][c11] implement ctime
677775d 
remove `ctime` and `ctime_r` from `clang-tidy`

this will be done in llvm#107445
@zimirza zimirza mentioned this issue Sep 5, 2024
Merged
zimirza added a commit to zimirza/llvm-project that referenced this issue Sep 6, 2024
@zimirza
remove symbols, since these will be implemented in
592e21c 
llvm#107445
@zimirza
Copy link
Contributor Author

zimirza commented Sep 28, 2024

This issue should also be about adding localtime and localtime_r to clang-tidy.

@zimirza zimirza changed the title clang-tidy: Add ctime and ctime_r to clang-tidy clang-tidy: Add ctime, ctime_r, localtime, and localtime_r to clang-tidy Sep 28, 2024
@EugeneZelenko EugeneZelenko added the enhancement Improving things as opposed to bug fixing, e.g. new or missing feature label Sep 28, 2024
zimirza pushed a commit to zimirza/llvm-project that referenced this issue Sep 28, 2024
[clang-tidy] add ctime and localtime to clang-tidy
4fb6994 
Closes llvm#107445
@zimirza zimirza linked a pull request Sep 28, 2024 that will close this issue
Open
zimirza pushed a commit to zimirza/llvm-project that referenced this issue Dec 26, 2024
[clang-tidy] add ctime and localtime to clang-tidy
24d7d39 
Closes llvm#107445
zimirza pushed a commit to zimirza/llvm-project that referenced this issue Jan 4, 2025
@zimirza
[clang-tidy] add ctime and localtime to clang-tidy
193e93c 
Closes llvm#107445
zimirza pushed a commit to zimirza/llvm-project that referenced this issue Apr 30, 2025
@zimirza
[clang-tidy] add ctime and localtime to clang-tidy
79d6622 
Closes llvm#107445
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
clang-tidy enhancement Improving things as opposed to bug fixing, e.g. new or missing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[clang-tidy] add ctime and localtime to clang-tidy zimirza/llvm-project
2 participants
@EugeneZelenko @zimirza