Add a file patch to circumvent broken module resolution in v3 generated repo d.ts file #1119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A live preview of this PR will be available at the URL(s) below. https://pr1119-52715a9---lit-dev-5ftespv5na-uc.a.run.app/ |
AndrewJakubowicz
changed the title
augustjk
approved these changes
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1111 and #1112
Context
TypeScript 5.0 creates a declaration file that typedoc doesn't resolve. This can be worked around by patching the file after
build:tssuch that it can be understood.I also bumped the Lit 3.0 pre-release commit hash.
Test
Tested because
pages.jsonhasn't changes and "check API data in sync" has passed.