Feature: Bookmarks #403
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,14 @@ | ||
| @using LinkDotNet.Blog.Web.Features.Home.Components | ||
|
|
||
| <CascadingAuthenticationState> | ||
| <Router AppAssembly="@typeof(Program).Assembly"> | ||
| <Found Context="routeData"> | ||
| <AuthorizeRouteView RouteData="@routeData" DefaultLayout="@typeof(MainLayout)"/> | ||
| </Found> | ||
| <NotFound> | ||
| <LayoutView Layout="@typeof(MainLayout)"> | ||
| <ObjectNotFound></ObjectNotFound> | ||
| </LayoutView> | ||
| </NotFound> | ||
| </Router> | ||
| </CascadingAuthenticationState> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| using System; | ||
| using System.Collections.Generic; | ||
| using System.Linq; | ||
| using System.Threading.Tasks; | ||
| using LinkDotNet.Blog.Domain; | ||
| using LinkDotNet.Blog.Infrastructure.Persistence.Sql; | ||
| using LinkDotNet.Blog.Web.Features.Services; | ||
| using Microsoft.EntityFrameworkCore; | ||
|
|
||
| namespace LinkDotNet.Blog.Web.Features.Bookmarks; | ||
|
|
||
| public class BookmarkService : IBookmarkService | ||
| { | ||
| private readonly ILocalStorageService localStorageService; | ||
|
|
||
| public BookmarkService(ILocalStorageService localStorageService) | ||
| { | ||
| this.localStorageService = localStorageService; | ||
| } | ||
|
|
||
| public async Task<bool> IsBookMarked(string postId) | ||
| { | ||
| if(string.IsNullOrEmpty(postId)) throw new ArgumentException(nameof(postId)); | ||
| await InitializeIfNotExists(); | ||
| var bookmarks = await localStorageService.GetItemAsync<HashSet<string>>("bookmarks"); | ||
|
|
||
| return bookmarks.Contains(postId); | ||
| } | ||
|
|
||
| public async Task<IReadOnlyList<string>> GetBookmarkedPostIds() | ||
| { | ||
| await InitializeIfNotExists(); | ||
| return await localStorageService.GetItemAsync<IReadOnlyList<string>>("bookmarks"); | ||
| } | ||
|
|
||
| public async Task ToggleBookmark(string postId) | ||
| { | ||
| await InitializeIfNotExists(); | ||
| if(string.IsNullOrEmpty(postId)) throw new ArgumentException(nameof(postId)); | ||
|
There was a problem hiding this comment. The same here - plus: The sanity check should be the first line in this code. No need to call |
||
|
|
||
| if (await IsBookMarked(postId)) | ||
| { | ||
| var bookmarks = await localStorageService.GetItemAsync<HashSet<string>>("bookmarks"); | ||
|
|
||
| bookmarks.Remove(postId); | ||
|
|
||
| await localStorageService.SetItemAsync("bookmarks", bookmarks); | ||
| } | ||
| else | ||
| { | ||
| var bookmarks = await localStorageService.GetItemAsync<HashSet<string>>("bookmarks"); | ||
|
|
||
| bookmarks.Add(postId); | ||
|
|
||
| await localStorageService.SetItemAsync("bookmarks", bookmarks); | ||
| } | ||
| } | ||
|
|
||
| private async Task InitializeIfNotExists() | ||
| { | ||
| if (!(await localStorageService.ContainKeyAsync("bookmarks"))) | ||
|
There was a problem hiding this comment. Just for consistency reasons: Can you wrap the if condition with brackets? if (...)
{
...
} |
||
| await localStorageService.SetItemAsync("bookmarks", new List<string>()); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| @page "/bookmarks" | ||
| @using LinkDotNet.Blog.Domain | ||
| @using LinkDotNet.Blog.Infrastructure.Persistence | ||
| @inject IBookmarkService BookmarkService | ||
| @inject IRepository<BlogPost> BlogPostRepository; | ||
|
|
||
| <section> | ||
|
There was a problem hiding this comment. Could we align this a bit better to other pages like the archive? <div class="container">
<h3 class="pb-3 fw-bold">Bookmarks</h3>
... |
||
| @if (bookmarkedPosts.Count <= 0) | ||
| { | ||
| <p>You have no bookmarks</p> | ||
| } | ||
| else | ||
| { | ||
| @foreach (var post in bookmarkedPosts) | ||
| { | ||
| <ShortBlogPost BlogPost="post" /> | ||
| } | ||
| } | ||
| </section> | ||
| <style> | ||
| section { | ||
|
There was a problem hiding this comment. Given the idea from above, this could be deleted |
||
| padding: 4rem; | ||
| } | ||
| </style> | ||
|
|
||
| @code { | ||
| private IReadOnlyList<BlogPost> bookmarkedPosts = []; | ||
|
|
||
| protected override async Task OnAfterRenderAsync(bool firstRender) | ||
| { | ||
| var ids = await BookmarkService.GetBookmarkedPostIds(); | ||
| bookmarkedPosts = await BlogPostRepository.GetAllByProjectionAsync(post => post, post => ids.Contains(post.Id)); | ||
|
There was a problem hiding this comment. nitpick: We could make a small sanity check if there are any ids. No need to go to the database if |
||
| StateHasChanged(); | ||
| } | ||
|
|
||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| <button @onclick="OnClickHandler"> | ||
linkdotnet marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| @if (!IsBookmarked) | ||
| { | ||
| <svg aria-hidden="true" xmlns="http://www.w3.org/2000/svg" width="24" height="24" fill="none" viewBox="0 0 24 24"> | ||
| <path stroke="currentColor" stroke-linecap="round" stroke-linejoin="round" stroke-width="2" d="m17 21-5-4-5 4V3.889a.92.92 0 0 1 .244-.629.808.808 0 0 1 .59-.26h8.333a.81.81 0 0 1 .589.26.92.92 0 0 1 .244.63V21Z"/> | ||
| </svg> | ||
| } | ||
| else | ||
| { | ||
| <svg aria-hidden="true" xmlns="http://www.w3.org/2000/svg" width="24" height="24" fill="currentColor" viewBox="0 0 24 24"> | ||
| <path d="M7.833 2c-.507 0-.98.216-1.318.576A1.92 1.92 0 0 0 6 3.89V21a1 1 0 0 0 1.625.78L12 18.28l4.375 3.5A1 1 0 0 0 18 21V3.889c0-.481-.178-.954-.515-1.313A1.808 1.808 0 0 0 16.167 2H7.833Z"/> | ||
| </svg> | ||
| } | ||
| </button> | ||
|
|
||
| <style> | ||
|
There was a problem hiding this comment. We either could move this into |
||
| svg :hover { | ||
| fill: grey; | ||
| } | ||
| button { | ||
| border: none; | ||
| background: var(--background); | ||
| } | ||
| </style> | ||
|
|
||
| @code { | ||
| [Parameter] public bool IsBookmarked { get; set; } | ||
| [Parameter] public EventCallback OnClick { get; set; } | ||
|
|
||
| private async Task OnClickHandler() | ||
| { | ||
| await OnClick.InvokeAsync(); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| using System.Collections.Generic; | ||
| using System.Threading.Tasks; | ||
| using LinkDotNet.Blog.Domain; | ||
|
|
||
| namespace LinkDotNet.Blog.Web.Features.Bookmarks; | ||
|
|
||
| public interface IBookmarkService | ||
| { | ||
| public Task<bool> IsBookMarked(string postId); | ||
|
There was a problem hiding this comment. I would also write |
||
| public Task<IReadOnlyList<string>> GetBookmarkedPostIds(); | ||
| public Task ToggleBookmark(string postId); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,4 +5,4 @@ | |
| Layout = "_Layout"; | ||
| } | ||
|
|
||
| <component type="typeof(App)" render-mode="ServerPrerendered" /> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.