-
Notifications
You must be signed in to change notification settings - Fork 655
Add {{.TempDir}} and {{.GlobalTempDir}} variables to host templates #3318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
89857c8
to
1f6fd20
Compare
Do you need to model "the real" $TMPDIR, or should it be something like $LIMA_TEMP instead? One concern was that there are many users sharing the |
This made default.yaml compatible with Windows. I managed to create and start VM w/o changes to template. Output of the mount command:
The |
9p mounts
|
I'm going to leave this PR open (and in draft mode) because I think adding the But the change to |
f76cd2f
to
cb47c5b
Compare
I've rebased this PR on latest This PR does introduce a user-visible change, in that I'm undecided if this is acceptable or not. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For compatibility {{ .Temp }}
should use /tmp
on macOS.
Probably we should have {{ .TempEnv }}
(or {{ .TempDynamic }}
) for $TMPDIR
I assume you meant Unix, not macOS.
How about we use On Windows both variables would be the same. |
To me this sounds like the former one is a file and the latter one is a directory |
How about The PS: I think I actually prefer |
👍 |
cb47c5b
to
0e6e56d
Compare
Allows writing the temp mount as mounts: - location: "{{.Temp}}/lima" mountPoint: /tmp/lima Note that on macOS this would use $TMPDIR and not /tmp, so would be a change in behaviour. It would not affect existing instances though. Signed-off-by: Jan Dubois <jan.dubois@suse.com>
0e6e56d
to
67a3361
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Allows writing the
/tmp/lima
mount asNote that on macOS this would use
$TMPDIR
and not/tmp
, so would be a change in behaviour. It would not affect existing instances though.