Use common Windows Subsystem path helper for calling tools on Windows #3300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arixmkii
force-pushed
the
windows-susbsystem-path
branch
from
67bdd85 to
f75c748
Compare
Signed-off-by: Arthur Sengileyev <arthur.sengileyev@gmail.com>
arixmkii
force-pushed
the
windows-susbsystem-path
branch
from
f75c748 to
9f52194
Compare
jandubois
reviewed
Mar 4, 2025
Comment on lines
+203
to
+205
| if err == nil && !strings.HasPrefix(dir, "/mnt/") { | ||
| dir = path.Join("/mnt", dir) | ||
| } |
There was a problem hiding this comment.
I didn't get a chance to review this PR properly, but wanted to comment that the /mnt prefix is just a default setting; it can be changed (or disabled) by the user in /etc/wsl.conf:
[automount]
enabled = true
root = /windir
So in general the directory name cannot be determined without checking /etc/wsl.conf inside the distro where you want to use it first.
There was a problem hiding this comment.
I'm aware of this setting, yet to see it in real life, though.
I was focused on the "default" configuration with this change. I have a fix in mind, will submit it this week and ask you to review #3303
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3164
Fixes #3167
Fixes #3215
This unifies use of
cygpathtool through the codebase. As currently there will be no support for Windows fork of OpenSSH (missing a lot of features, not only mux, but also basic AF_UNIX) and in future if such support is considered it will have conditional handling in he codebase.I switched the tool to generate Unix like paths instead of hybrid ones. They are fully understand by msys2 tooling, so are safe to use to all tools in use. Additionally this opened opportunity to use
wslpathas drop-in replacement ofcygpathand provides capabilities to use tooling hosted inside WSL container, where full set of feature is available, which in turns makes QEMU support easier to achieve (mux for port forwarding with SSH forwarder, etc).There is some special handling added for
/mnt/prefixes, because it is the difference betweencygpathandwslpathoutputs. So, it is a compatibility supporting part.