Support for deterministic ip for user-v2 network #1801
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkihiroSuda
reviewed
Sep 18, 2023
| if err != nil { | ||
| return "", err | ||
| } | ||
| sockPath := filepath.Join(filepath.Join(dir, name), "leases.json") |
There was a problem hiding this comment.
Could you update docs/internal.md ?
AkihiroSuda
reviewed
Sep 18, 2023
cmd/limactl/usernet.go
Outdated
| @@ -24,6 +24,7 @@ func newUsernetCommand() *cobra.Command { | |||
| hostagentCommand.Flags().String("listen", "", "listen on a Unix socket and receive Bess-compatible FDs as SCM_RIGHTS messages") | |||
| hostagentCommand.Flags().String("subnet", "192.168.5.0/24", "sets subnet value for the usernet network") | |||
| hostagentCommand.Flags().Int("mtu", 1500, "mtu") | |||
| hostagentCommand.Flags().StringToString("leases", nil, "pass default static leases for startup") | |||
There was a problem hiding this comment.
Could you explain the map key and the value in the usage string?
balajiv113
force-pushed
the
ip-user-v2
branch
from
aad699d to
b90ecb9
Compare
Signed-off-by: Balaji Vijayakumar <kuttibalaji.v6@gmail.com>
balajiv113
force-pushed
the
ip-user-v2
branch
from
b90ecb9 to
c0bce3e
Compare
AkihiroSuda
approved these changes
Sep 19, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1785