Skip to content

fix: allow keys to do sync sign/verify #2258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 28, 2023
Merged

fix: allow keys to do sync sign/verify #2258

merged 1 commit into from
Nov 28, 2023

Conversation

achingbrain
Copy link
Member

@achingbrain achingbrain commented Nov 28, 2023 •
edited
Loading

Removes unnecessary async from Ed/Secp keys sign/verify methods.

Ed is sync everywhere, Secp is sync in node but async in browsers.

Follow up to #1963

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

@achingbrain
fix: allow keys to do sync sign/verify
1bdedf7 
Removes unnecessary async from Ed/Secp keys sign/verify methods.

Ed is sync everywhere, Secp is sync in node but async in browsers.
@achingbrain achingbrain requested a review from a team as a code owner November 28, 2023 10:24
@achingbrain achingbrain merged commit dd7d17c into main Nov 28, 2023
@achingbrain achingbrain deleted the fix/remove-unnecessary-async branch November 28, 2023 10:55
This was referenced Jan 18, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@achingbrain