-
Notifications
You must be signed in to change notification settings - Fork 479
Merge peer-id & peer-info into one, Merge peer-book into js-libp2p #453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
While at it, rename the module name to be |
I think what I'd really like to see is for peer-info to go away altogether. What it does could and should, imo, be managed by the peer-book (PeerStore, which would be great to rename as part of pulling this into libp2p to avoid confusion with go and the specs). Everything ultimately gets housed in the PeerStore anyway, so fully centralizing it there would be ideal, and it would remove a layer of complexity. cc: @vasco-santos |
I agree with jacob here! Peerbook should own the responsibilities of +1 on renaming this to |
Just note that there are multiple modules that require the concept of a
👍🏽 |
Now that PeerStore is becoming part of js-libp2p with the async await refactor. Can we also get peer-id and peer-info merged into just |
Yes, I have on my list to tackle that soon :) |
Released in 0.28 |
`any-signal` can now remove the event listeners it installs preventing a source of memory leaks.
## [8.0.7](libp2p/js-libp2p-kad-dht@v8.0.6...v8.0.7) (2023-04-13) ### Dependencies * update any-signal to 4.x.x ([libp2p#453](libp2p/js-libp2p-kad-dht#453)) ([852d757](libp2p/js-libp2p-kad-dht@852d757))
We've talked this in a PR but creating a issue so that we don't miss it.
The text was updated successfully, but these errors were encountered: