Skip to content

30+ Broken links in readme. #2423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MichaelJCole opened this issue Feb 24, 2024 · 3 comments · Fixed by #2497 or #2495
Closed

30+ Broken links in readme. #2423

MichaelJCole opened this issue Feb 24, 2024 · 3 comments · Fixed by #2497 or #2495
Labels
need/triage Needs initial labeling and prioritization

Comments

@MichaelJCole
Copy link
Contributor

  • Version:
    Current

  • Platform:
    Github

  • Subsystem:
    Documentation

Severity:

High?

Description:

Hi, thanks for this visionary project. I noticed some links in the readme are broken.

See broken links in the attached file:
libp2p.github.io.csv
libp2p.github.io.html.zip

Steps to reproduce the error:

docker run --rm dcycle/broken-link-checker:3 -r 1 https://libp2p.github.io/js-libp2p/index.html  > ~/Desktop/libp2p.github.io.csv 
@MichaelJCole MichaelJCole added the need/triage Needs initial labeling and prioritization label Feb 24, 2024
@achingbrain
Copy link
Member

Thanks for opening this - would you like to open a PR that updates the links to point to the new locations?

@MichaelJCole
Copy link
Contributor Author

MichaelJCole commented Mar 13, 2024

Hi @achingbrain thank you responding. How could I know how to do that?

I really have no idea how your project is structured or should be documented or how it works. How could I know how it should work enough to document it?

I wasted a bunch of time trying to customize Kubo only to realize it has 47 repos and doesn't make any sense. I'm realizing libp2p and helia have the same problem.

I've been filing bugs on js-store (ipfs/js-stores#300 and ipfs/js-stores#299). I finally worked that out, but I burned a bunch of time on it. I ran into problems with simple-metrics and didn't file issues. I'm not sure what is supposed to work and what is abandoned. I can do drive-by contributions improving something that already exists. I can make PR's if I know how it's supposed to work.

If yall are serious about inviting contributions, start with a README and documentation - I added the link checker so it should be a few minutes of work for someone who wrote it. Otherwise, it just seems like a lazy request to spend hours cleaning up someone else's unfinished work. I can't do that, I have to create value for my users.

There's alot of opportunity and value in what's already here - it just needs to be brought over the finish line.

@SgtPooki
Copy link
Member

I ran the docker broken link checker and checked into GETTING_STARTED.md broken link. it looks like packages/libp2p/README.md is linking to ./doc/GETTING_STARTED.md which exists on the root.

@achingbrain I think some of the doc building in aegir isn't handling links to github docs properly. Also, looking at the output of .docs after building locally, it doesn't seem to contain any markdown files:

╰─ ✔ ❯ ls .docs
assets         classes        enums          functions      hierarchy.html index.html     interfaces     modules        types          variables


╰─ ✔ ❯ ls .docs/**/*.md
zsh: no matches found: .docs/**/*.md

@MichaelJCole for now, you should probably use links from the github README root cause those will resolve properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need/triage Needs initial labeling and prioritization
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants