Skip to content

fix: replace node buffers with uint8arrays #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 12, 2020
Merged

fix: replace node buffers with uint8arrays #42

merged 2 commits into from
Aug 12, 2020

Conversation

achingbrain
Copy link
Member

BREAKING CHANGE:

  • all useage of node Buffers has been replaced with Uint8Arrays
  • all deps now use Uint8Arrays instead of node Buffers

@achingbrain
fix: replace node buffers with uint8arrays
ce9dd38 
BREAKING CHANGE:

- all useage of node Buffers has been replaced with Uint8Arrays
- all deps now use Uint8Arrays instead of node Buffers
@achingbrain
Copy link
Member Author

This updates the deps but the tests won't pass until ipfs-http-client has had it's deps updated.

@achingbrain achingbrain mentioned this pull request Aug 11, 2020
Closed
64 tasks
jacobheun
jacobheun approved these changes Aug 12, 2020
View reviewed changes
Copy link
Contributor

@jacobheun jacobheun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests were actually failing because it was assuming a cid exists on a new node (help docs), which could change with new versions. I fixed the issue in the tests by explicitly adding data to ipfs before trying to provide it.

@jacobheun jacobheun merged commit 381815e into master Aug 12, 2020
@jacobheun jacobheun deleted the fix/replace-node-buffers-with-uint8arrays branch August 12, 2020 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobheun jacobheun jacobheun approved these changes

@vasco-santos vasco-santos Awaiting requested review from vasco-santos

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@achingbrain @jacobheun