Bump faraday-http-cache version #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shyvy88 This looks great-- thanks for the contribution! |
|
Sure, no worries. |
eli-darkly
added a commit
that referenced
this pull request
Jun 26, 2018
fail fast in initialization if there's a 401
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #61
Bumping the version caused an issue with LaunchDarkly::ThreadSafeMemoryStore not implementing a delete method.
Implemented the delete method - tests pass.
UAT'ed the gem locally for using feature toggles and the toggle? method. Haven't done any further testing in that regard.
Running the gem in production now without further issues.