New methods for fetching all user settings and all feature flags #51
Conversation
|
HoundCI seems to be having issues unrelated to these changes. |
|
👍 |
| end | ||
| end | ||
|
|
||
| def get_user_settings(user) | ||
| Hash[all_flags.map { |key, feature| [key, evaluate(feature, user)]}] |
There was a problem hiding this comment.
I think we should send feature events here.
|
Almost have this integrated, but wanted to mention that I ran into the same problem mentioned at sourcelevel/faraday-http-cache#38. There's a gem that supposedly works around the problem that ultimately lies with Net::HTTP, https://github.com/ma2gedev/faraday-encoding, but for now I just changed the serializer to Marshal as in [https://github.com/24pullrequests/contribulator/pull/47/files](this other project). I also added back our |
|
@slumos Happy to take both changes (the add_user_override and the Marshal serializer) if you submit a PR. Thanks! |
Below copied from launchdarkly#51 (comment) Almost have this integrated, but wanted to mention that I ran into the same problem mentioned at sourcelevel/faraday-http-cache#38. There's a gem that supposedly works around the problem that ultimately lies with Net::HTTP, https://github.com/ma2gedev/faraday-encoding, but for now I just changed the serializer to Marshal as in https://github.com/andrew/contribulator/pull/47/files. I also added back our LDClient#add_user_override to my fork. Not sure if you were planning to implement that, but if not then I'll move it elsewhere so we can use your gem unmodified.
|
This is working well for us. |
|
Ping @jkodumal. Will this get merged soon? |
New methods for fetching all user settings and all feature flags
fix behavior of debug & index events
If streaming is enabled, these new methods will not make remote calls