Skip to content

Update net-http-persistent versions allowed #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

CodingAnarchy
Copy link

@CodingAnarchy CodingAnarchy commented Dec 11, 2018

I'm running into Gemfile conflicts trying to integrate this client into a Rails 5.2 application, because both net-http-persistent and concurrent-ruby are significantly out of date in this gem.

These changes are primarily the other gems dropping support for old versions of Ruby, so this should have minimal impact here.

@eli-darkly
Copy link
Contributor

eli-darkly commented Dec 11, 2018

I understand the need to change this, but I'm not sure this particular change is the right approach. There may be existing developers who are using a non-current version of those gems for whatever reason, in which case this would be a breaking change for them.

As far as I can tell (I'm still going through the changelogs), there's nothing in the 2.x-to-3.x or 1.0.x-to-1.1.x transition that affects our code. In that case, I don't think it makes sense for the SDK to impose a higher minimum version of either of those gems. Instead, we could do something like [">= 2.9", "< 4.0"] and [">= 1.0.4", "< 1.2.0"] (that last one feels a bit arbitrary, we have no reason to think that 1.2.0 will be a breaking change—it certainly shouldn't be according to semver—so maybe it should just be "< 2.0"). What do you think?

@CodingAnarchy
Copy link
Author

I agree, that's definitely a safer modification to the requirement range. I can go ahead and update that.

@eli-darkly
Copy link
Contributor

We just released v5.4.2 which fixes the concurrent-ruby version range, but I forgot about wanting to allow net-http-persistent 3.x so I'll have to do another patch release for that.

@CodingAnarchy
Copy link
Author

@eli-darkly I've updated this pull request to do that, if you want to just merge that in. Either way, thanks.

@CodingAnarchy CodingAnarchy changed the title Update old requirement versions that cause Gemfile conflicts Update net-http-persistent versions allowed Jan 7, 2019
@eli-darkly
Copy link
Contributor

I still need to do a little more checking to make sure that net-http-persistent 3.x really will work for us— it does have at least one breaking API change— but I'll know soon.

@eli-darkly eli-darkly mentioned this pull request Jan 11, 2019
@eli-darkly
Copy link
Contributor

Just released version 5.4.3 which includes this change. Sorry for the delay - I had to make sure this wouldn't cause us problems in the future because there will be some changes to the networking code in 5.5.0. But it's fine.

@eli-darkly eli-darkly closed this Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants