-
Notifications
You must be signed in to change notification settings - Fork 66
Synchronous reading of bootstrap #162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks for the feedback, @edvinerikson! While LDClient's current behavior works as designed and documented, the behavior you described makes sense to us. We'll take a look at implementing this and will get back to you soon. |
This has been changed in the 2.12.3 release to behave in the way you expected (which was also the way it behaved in earlier versions of the SDK; unfortunately we hadn't documented the change, hence I consider this a bug fix). |
Thank you for such a fast response! 👍🏼 |
change TS declarations to prefer interfaces over types
Describe the bug
Calling
variation
before the ready event fire returnundefined
despite having bootstrap config provided.To reproduce
Steps to reproduce the behavior.
https://jsbin.com/xuyatiniva/1/edit?html,output
Expected behavior
I expect that the reading of bootstrap is synchronous to allow for simpler integration in SSR react apps.
SDK version
2.12.2
Additional context
We will have to create a mock client for now and switch to the real client once the ready event is emitted.. but we're not really fond of that idea.
The text was updated successfully, but these errors were encountered: