chore(list): updated dev (#DS-3517) #705
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 06571b0): https://koobiq-next--prs-705-c6pwo71g.web.app (expires Sat, 03 May 2025 10:56:51 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c |
NikGurev
approved these changes
Apr 28, 2025
lskramarov
reviewed
Apr 28, 2025
| encapsulation: ViewEncapsulation.None | ||
| }) | ||
| export class DemoComponent { | ||
| export class ListDev { |
There was a problem hiding this comment.
название должно быть одинаковым во всех примерах, нужно вернуть DemoComponent
| `, | ||
| changeDetection: ChangeDetectionStrategy.OnPush | ||
| }) | ||
| export class DevListExamples {} |
There was a problem hiding this comment.
Это название тоже нужно сделать одинаковым для всех примеров
| @@ -1,3 +1,5 @@ | |||
| <dev-list-examples /> | |||
There was a problem hiding this comment.
И этот селектор нужно сделать одинаковым docs-examples (в задаче одинаковые имена описаны)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.