Skip to content

RBAC: Make it possible to use regex for values #663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
Mar 20, 2025
Merged

RBAC: Make it possible to use regex for values #663

merged 23 commits into from
Mar 20, 2025

Conversation

francoisvandenplas
Copy link
Contributor

@francoisvandenplas francoisvandenplas commented Nov 19, 2024 •
edited by Haarolean
Loading

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)
Rbac now handle regex in values
Fixes #300

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@francoisvandenplas francoisvandenplas requested a review from a team as a code owner November 19, 2024 10:36
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress area/rbac Related to Role Based Access Control feature status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Nov 19, 2024
@callaertanthony
Copy link
Contributor

Hey ! Any chance to see this PR merged ?

@Haarolean
Copy link
Member

Haarolean commented Jan 14, 2025 •
edited
Loading

Hey ! Any chance to see this PR merged ?

sorry, will take a look this week

@Haarolean Haarolean added this to the 1.2 milestone Jan 14, 2025
@Haarolean Haarolean added type/enhancement En enhancement/improvement to an already existing feature scope/backend Related to backend changes and removed status/triage/manual Manual triage in progress labels Jan 14, 2025
@Haarolean Haarolean changed the title Issues/300 regex for rbac RBAC: Make it possible to use regex for values Jan 14, 2025
Haarolean
Haarolean requested changes Feb 12, 2025
View reviewed changes
Copy link
Member

@Haarolean Haarolean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for covering this with tests, that's really helpful!
Left a few minor inline comments

@callaertanthony
Copy link
Contributor

hey @Haarolean , is it possible for you to give a look again ? many thanks

@Haarolean
Copy link
Member

@callaertanthony hey, good point! We've discussed this: we believe a better approach would be introducing a new boolean param like isRegex (nullable & defaults to false for back compatibility), which will indicate whether we should treat the value as regex or a string literal. This will guarantee backward compatibility AND reduce confusion if multiple fields are used instead. What do you think?

@Haarolean Haarolean self-requested a review February 27, 2025 15:09
@callaertanthony
Copy link
Contributor

thanks @Haarolean , @francoisvandenplas I created this pr with the change : francoisvandenplas#1

@Haarolean
Copy link
Member

thanks @Haarolean , @francoisvandenplas I created this pr with the change : francoisvandenplas#1

could you rebase this branch instead please?

@Haarolean Haarolean moved this from PR Approved to Changes requested in Release 1.2 Feb 28, 2025
@francoisvandenplas
Copy link
Contributor Author

Hello,
@Haarolean could you have a look ?
Thanks !

Haarolean
Haarolean requested changes Mar 14, 2025
View reviewed changes
Copy link
Member

@Haarolean Haarolean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one minor thing and we're good to merge. @francoisvandenplas would you mind updating docs as well?
https://github.com/kafbat/ui-docs

@Haarolean Haarolean moved this from Changes requested to In Review in Release 1.2 Mar 19, 2025
@Haarolean Haarolean self-requested a review March 20, 2025 11:36
@github-project-automation github-project-automation bot moved this from In Review to PR Approved in Release 1.2 Mar 20, 2025
@Haarolean Haarolean merged commit 3074abc into kafbat:main Mar 20, 2025
14 of 15 checks passed
@github-project-automation github-project-automation bot moved this from PR Approved to Done in Release 1.2 Mar 20, 2025
@Haarolean
Copy link
Member

@francoisvandenplas @callaertanthony thanks for your contribution! We just need to update docs now

git-halinka pushed a commit to sainsburys-tech/kafka-ui that referenced this pull request Mar 20, 2025
@francoisvandenplas @Haarolean
@callaertanthony @git-halinka
RBAC: Make it possible to use regex for values (kafbat#663)
3aef830 
Co-authored-by: François <francois.vandenpla@decathlon.com>
Co-authored-by: Roman Zabaluev <gpg@haarolean.dev>
Co-authored-by: Callaert Anthony <callaertanthony@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@callaertanthony callaertanthony callaertanthony left review comments

@germanosin germanosin germanosin approved these changes

@Haarolean Haarolean Haarolean approved these changes

Assignees

@francoisvandenplas francoisvandenplas

Labels
area/rbac Related to Role Based Access Control feature scope/backend Related to backend changes status/triage/completed Automatic triage completed type/enhancement En enhancement/improvement to an already existing feature
Projects
No open projects
Release 1.2
Status: Done
Milestone
1.2
Development

Successfully merging this pull request may close these issues.

RBAC: Make it possible to use regex for values
4 participants
@francoisvandenplas @callaertanthony @Haarolean @germanosin