Add base.handlers.get_current_request() #6041
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flupke
force-pushed
the
add-get-current-request
branch
from
d722d4b to
70e9560
Compare
This function allows to retrieve the current web request in async contexts. Retrieving the current context can be useful for example when customizing Enterprise Gateway RemoteProcessProxy, to retrieve authentication headers. The implementation makes uses of Python 3.7's new contextvars module. There are backports efforts for 3.6: - https://pypi.org/project/aiocontextvars/ - does not have automatic asyncio support - https://pypi.org/project/contextvars/ - which doesn't have it either. The tracking issue on this matter has been stale for 3 years now, and the conclusion of the discussion is "upgrade to a newer version of Python": MagicStack/contextvars#2 Since notebook has no control on the event loop it is running into, I preferred to drop Python 3.6 support.
flupke
force-pushed
the
add-get-current-request
branch
from
70e9560 to
c57a166
Compare
flupke
commented
Apr 22, 2021
Comment on lines
+943
to
+947
| def get_current_request(): | ||
| """ | ||
| Get :class:`tornado.httputil.HTTPServerRequest` that is currently being processed. | ||
| """ | ||
| return _current_request_var.get(None) |
There was a problem hiding this comment.
Could you please point me to the right place in tests to cover this?
|
Hi @flupke. I think this pull request is probably better suited for
You should find the source bases extremely similar (although the test frameworks vary quite a bit). As for where to apply test code, and assuming I'm understanding the change, you could probably take a look at the API kernels tests and not await the kernel start request and immediately follow it with one of these requests. |
|
Ok thanks, I was not aware of this change (we're still using an older version), I will come back once we update :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function allows to retrieve the current web request in async
contexts.
Retrieving the current context can be useful for example when
customizing Enterprise Gateway RemoteProcessProxy, to retrieve
authentication headers.
The implementation makes uses of Python 3.7's new contextvars module.
There are backports efforts for 3.6:
https://pypi.org/project/aiocontextvars/ - does not have automatic
asyncio support
https://pypi.org/project/contextvars/ - which doesn't have it either.
The tracking issue on this matter has been stale for 3 years now, and
the conclusion of the discussion is "upgrade to a newer version of
Python": asyncio support MagicStack/contextvars#2
Since notebook has no control on the event loop it is running into, I
preferred to drop Python 3.6 support.