-
Notifications
You must be signed in to change notification settings - Fork 183
Refactored container for simplicity #586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This sounds great to ke - my main question is what logic we are losing from the bootstrap helper class. I guess there was just a bunch of stuff we weren't using? Also we should totally do something like this for the jupyter book and pydata sphinx themes... |
The bootstrap container used a media query to set different max widths for all content at different viewports. Instead, I've defined two fixed max widths, a narrower one for copy and a wider one for art. Both will fill 100% at mobile devices. Pretty subtle, but helps make the code more declarative and consistent. Bootstrap also had some crazy negative margin stuff I cut. |
This will fix #541 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry for the slow turnaround, was traveling back to California
This looks good to me - I like that we are simplifying our CSS and HTML a bit, removing unnecessary rules and also removing dependencies on Bootstrap. The new width for copy sounds reasonable to me, I think it's a nice improvement.
@palewire I see you've been pushing more updates to this PR, is there something else you want to finish up or is this good to go?
It's good to go. I just killed some cruft. |
This pull request replaces the container logic of bootstrap, and our numerous hacks on top of it, with a less complex system. Pages should look virtually the same afterward.
Here's what it does: