-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Add Kotlin Sequence
support for @TestFactory
, @MethodSource
, and @FieldSource
#3377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Kotlin Sequence
support for @TestFactory
, @MethodSource
, and @FieldSource
#3377
Conversation
8a0a767
to
52d6c31
Compare
junit-platform-commons/src/main/java/org/junit/platform/commons/util/CollectionUtils.java
Outdated
Show resolved
Hide resolved
junit-platform-commons/src/main/java/org/junit/platform/commons/util/CollectionUtils.java
Outdated
Show resolved
Hide resolved
52d6c31
to
f32d798
Compare
Hello, I am curious if my changes in response to the review satisfy the requirements. I would love to hear what you think and if it can be merged to the main branch |
f32d798
to
9e7a9a3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hanszt Sorry for the delay! I think this would be a very useful change.
junit-platform-commons/src/main/java/org/junit/platform/commons/util/CollectionUtils.java
Outdated
Show resolved
Hide resolved
junit-platform-commons/src/main/java/org/junit/platform/commons/util/CollectionUtils.java
Outdated
Show resolved
Hide resolved
No worries. I can imagine you are busy. I'm glad you think it is a good improvement. |
9e7a9a3
to
4ce948f
Compare
Sequence
support for @TestFactory
methods
4ce948f
to
8a9d199
Compare
@marcphilipp Thanks for the update. Congratz on the investment of Sovereign Tech Fund in Junit5 by the way! 🎉 |
Examples of benefits: - Kotlin Sequence support for @testfactory - Kotlin Sequence support for @MethodSource - Classes that expose an Iterator returning method, can be converted to a stream. Issue: junit-team#3376 I hereby agree to the terms of the JUnit Contributor License Agreement.
8a9d199
to
46fe660
Compare
Sequence
support for @TestFactory
methodsSequence
support for @TestFactory
, @MethodSource
, and @FieldSource
@hanszt I pushed a few commits of my own. Do you have time to take a look? |
I went ahead with the merge. Feedback is still welcome, though! |
Hi @marcphilipp , Nice that the pull request is merged! Your commits and polishing of the implementation looks good! I would really appreciate it if I could be added to the junit5 contributors list. And maybe also add the Github achievement batch that a pull request has been merged? Or is that something that Github decides? Thanks in advance! Looking forward to using it in my projects and our Kotlin codebase at Drillster! |
Sure thing! We list all first-time contributors as part of the release description on GitHub. So, just a little longer! 🙂 Thanks again for your contribution! 🙏 |
Overview
Add support for converting
Iterator
-providing classes to aStream
inorg.junit.platform.commons.util.CollectionUtils
.Sequence
support for@TestFactory
,@MethodSource
, and@FieldSource
#3376I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@API
annotations