dev -> main (Apr 23) #1331
Open
dev -> main (Apr 23) #1331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
…into c/graphql-server
chore: Replace Postgraphile with Hasura for GraphQL service
fix: Reference not found error re-raise
chore(gateway): Expose GraphQL API
feat: Add a flag to optionally include API response content
…tion refactor: Move query parameters validation to beartype
chore(hasura): Add hasura metadata
…dating service checks into utility functions
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
refactor(docs): update documentation structure and remove deprecated …
… logic in browser use examples
fix(cookbooks, docs): update string formatting and improve evaluation…
feat(agents-api): enhance health check endpoint to monitor multiple s…
fix(cookbooks): Fix regressed issues in cookbooks
fix(documentation): Add missing $ to expression
feat(integrations-service): Add mailgun integration
feat(agents-api): add list available models endpoint
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
|||||||||||||||
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Changes requested ❌
Reviewed everything up to 5599f40 in 6 minutes and 28 seconds. Click for details.
- Reviewed
10601lines of code in118files - Skipped
11files when reviewing. - Skipped posting
62draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. .env.example:133
- Draft comment:
New HASURA configuration variables are added. Please ensure these are documented in the README so users know how to configure Hasura in their environment. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is asking the PR author to document configuration variables in the README. While documentation is important, the comment is essentially asking the author to ensure something is done, which violates the rule against asking the author to ensure something is done. Therefore, this comment should be removed.
2. agents-api/agents_api/activities/execute_api_call.py:73
- Draft comment:
The code now conditionally includes response content using the 'include_response_content' flag. Verify that the b64encode import is available and that this behavior is consistently applied for both true and false values. Consider adding a brief inline comment clarifying how the flag is prioritized. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
3. agents-api/agents_api/queries/docs/list_docs.py:60
- Draft comment:
Validation checks for sort direction and sort field have been commented out here; however, tests expect HTTPExceptions with specific messages. Please ensure that parameter validation for fields like 'direction' and 'sort_by' is consistently enforced either via annotations or through explicit checks. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
4. agents-api/agents_api/autogen/Tools.py:1493
- Draft comment:
Mailgun integration types and update models are added. Please double-check that the use of Literal for the 'provider' field and the overall structure matches the API contract. Additionally, ensure that the documentation for optional fields (e.g., 'method', 'setup', 'arguments') is updated. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
5. typespec/agents/endpoints.tsp:16
- Draft comment:
The new listModels endpoint is added. Confirm that the documentation in the OpenAPI and Typespec outputs is consistent with the implementation. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
6. integrations-service/integrations/utils/integrations/mailgun.py:1
- Draft comment:
The Mailgun utility function added uses exponential backoff and validates email formats. Ensure that the domain extraction logic for the Mailgun API URL (prefixing with 'email.' when needed) is consistent with Mailgun's requirements. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%The comment is asking the author to ensure consistency with Mailgun's requirements, which is a form of asking for confirmation or verification. This violates the rule against asking the PR author to confirm or ensure behavior. The comment does not provide a specific suggestion or point out a specific issue in the code.
7. agents-api/agents_api/activities/execute_api_call.py:70
- Draft comment:
The new conditional for including response content is a good approach; however, the precedence between the function parameter and the api_call attribute is not clearly documented. Consider adding a comment to clarify which one takes priority if both are provided. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
8. agents-api/agents_api/queries/agents/list_agents.py:73
- Draft comment:
Explicit validations for 'direction' and 'sort_by' have been commented out. Since the parameters are now Liniteral types, FastAPI's built-in validation will trigger, potentially leading to different error responses. Confirm that this change is intentional and that tests align with the new behavior. - Reason this comment was not posted:
Comment looked like it was already resolved.
9. agents-api/tests/test_agent_queries.py:129
- Draft comment:
Test cases expecting a HTTPException with status 400 and specific error messages may now receive 422 errors due to FastAPI's automatic validation. Verify that the API error codes and messages are updated consistently across the tests. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
10. integrations-service/integrations/utils/integrations/mailgun.py:1
- Draft comment:
The regex used for email validation is quite simplistic and may not accept all valid email formats. Consider using a more robust regex or a dedicated email validation library. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 20% vs. threshold = 50% The current regex handles basic email validation which is likely sufficient for most cases. The code is used for validation before sending to Mailgun's API, which will do its own validation. Making the regex more complex could introduce maintenance issues and potential bugs. The simple regex acts as a basic sanity check which is appropriate for this use case. The comment correctly points out that the regex could miss some valid email formats. A more robust validation could prevent some API calls from failing. The current simple validation is sufficient as a first line of defense, with Mailgun's API providing the ultimate validation. Over-validation at this stage could reject valid emails that Mailgun would accept. The comment should be deleted as the current simple validation is appropriate for its purpose as an initial sanity check before the API call.
11. integrations-service/integrations/utils/integrations/mailgun.py:25
- Draft comment:
The logic that prefixes the extracted domain with 'email.' if it doesn't already start with that could be fragile. Verify that this convention holds for all expected Mailgun domains, or consider parameterizing this behavior. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 20% vs. threshold = 50% The comment raises a valid concern about hardcoding domain prefixing, but it's phrased as a request to verify rather than pointing out a clear issue. It asks the author to "verify" and "consider" rather than identifying a specific problem. Without access to Mailgun's documentation or requirements, we can't be certain this is incorrect. The domain prefixing could indeed be problematic if Mailgun's domain requirements are different. The comment might be identifying a real architectural issue. However, the comment violates our rules by asking for verification rather than pointing out a clear issue. If there was a specific problem with the domain handling, it should state that directly. The comment should be removed because it asks for verification rather than identifying a clear issue, and we don't have strong evidence that the current implementation is incorrect.
12. schemas/create_agent_request.json:403
- Draft comment:
The default value for 'confidence' has been changed from 0 to 0.5 in several JSON schemas. Ensure that this change is intentional and that consumers of these schemas are updated accordingly. - Reason this comment was not posted:
Confidence changes required:50%<= threshold50%None
13. agents-api/agents_api/autogen/Tools.py:1490
- Draft comment:
New Mailgun integration definitions and argument models have been added. Verify that these models cover all required fields for Mailgun interactions and that they are integrated seamlessly with existing update and creation flows. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
14. memory-store/migrations/000036_usage.up.sql:1
- Draft comment:
The migration for the 'usage' table, including conversion to a hypertable and index creation, appears well-structured. Consider adding inline comments regarding expected data volumes and performance implications for future maintainability. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 20% vs. threshold = 50% While documentation about expected data volumes could be helpful, the implementation already shows strong awareness of performance considerations. The comment is more of a "nice to have" suggestion rather than identifying a clear issue. It's asking for additional documentation rather than pointing out a concrete problem that needs fixing. The comment could have merit since understanding data volumes is important for database design. Future maintainers might benefit from explicit documentation of scale expectations. However, the implementation already demonstrates careful consideration of scale through its use of hypertables and appropriate indexing. Additional inline comments would be purely informative rather than actionable. The comment should be deleted as it violates the rule against purely informative comments and doesn't identify a clear code change that's required.
15. typespec/agents/endpoints.tsp:16
- Draft comment:
The new 'listModels' endpoint is a useful addition. Ensure that its error handling and response structure are consistent with the rest of the API. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
16. llm-proxy/litellm-config.yaml:19
- Draft comment:
New Gemini models have been added; ensure that environment variables like GEMINI_API_KEY are correctly configured and that any usage policies for these models are adhered to. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is asking the PR author to ensure that environment variables are configured correctly and that usage policies are adhered to. This falls under the category of asking the author to ensure something, which is against the rules.
17. CHANGELOG.md:33
- Draft comment:
Typographical error: The month in the heading is spelled as 'Apri'. Please change it to 'April'. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 20% vs. threshold = 50% While this is a real typo in changed code, changelogs are primarily for human readers and this is a very minor cosmetic issue. The meaning is still completely clear. The rules say not to make obvious or unimportant comments. However, since this is a public-facing document that represents the company, maintaining professional quality could be considered important. I might be overthinking this - the rules clearly state not to make obvious or unimportant comments. A simple typo that doesn't affect functionality probably falls into this category. The critique is valid - while professional documentation is important, this type of minor typo can be caught in many other ways and doesn't warrant a PR comment. This comment should be removed as it points out an obvious and unimportant issue that doesn't affect functionality.
18. agents-api/agents_api/autogen/Tools.py:266
- Draft comment:
Typographical suggestion: The docstring for the 'download_pdf' field currently reads "The download the pdf of the results". Consider rephrasing it to something clearer like "Whether to download the PDF of the results". - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
19. agents-api/agents_api/autogen/Tools.py:1428
- Draft comment:
Typographical suggestion: The docstring for the 'provider' field in LlamaParseIntegrationDef states "The provider must be 'LlamaParseSetup'". Since the actual provider value is 'llama_parse', consider updating the docstring to "The provider must be 'llama_parse'" for consistency. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
20. agents-api/agents_api/queries/usage/create_usage_record.py:57
- Draft comment:
Typographical issue: In the SQL query definition, the closing parenthesis on line 57 (and similarly on line 67) is immediately followed by a colon. This likely should be a plain ')' without the colon to properly close the list of columns (and values). Please review and correct if this is unintended. - Reason this comment was not posted:
Comment looked like it was already resolved.
21. agents-api/tests/test_files_queries.py:1
- Draft comment:
The header comment on line 1 reads "Tests for entry queries". Since the tests in this file are specifically for file queries, consider updating it to "Tests for file queries" to avoid confusion. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
22. documentation/advanced/architecture-deep-dive.mdx:56
- Draft comment:
Typo: In the 'Task & Execution' card (line 56), 'Github Actions-style workflows' should be corrected to 'GitHub Actions-style workflows' to properly reflect GitHub's branding. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
23. documentation/advanced/chat.mdx:95
- Draft comment:
Typographical error: 'Chat endpint' should be corrected to 'Chat endpoint' for clarity. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
24. documentation/advanced/lifecycle.mdx:3
- Draft comment:
Typographical suggestion: In the frontmatter description on line 3, consider changing 'Understanding the Lifecycle of Task when executed in Julep' to 'Understanding the Lifecycle of a Task when executed in Julep' for improved clarity and readability. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
25. documentation/advanced/localsetup.mdx:8
- Draft comment:
Typo: 'Juelp' should be 'Julep'. Please correct the product name to maintain consistency. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
26. documentation/advanced/localsetup.mdx:46
- Draft comment:
Typo: 'SeadweedFS' should be 'SeaweedFS'. Please update the spelling to match the correct tool name. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
27. documentation/advanced/localsetup.mdx:68
- Draft comment:
Grammatical issue: In the phrase 'a JWT token locally that act as an API KEY', 'act' should be 'acts' to agree with 'token'. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
28. documentation/advanced/new-syntax.mdx:26
- Draft comment:
Typo: In the bullet point for_x(line 26), there's an extra space between the dash and 'Has been removed'. Please remove the extra space for consistency. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
29. documentation/advanced/new-syntax.mdx:41
- Draft comment:
Typo: In several new syntax code samples (for instance, lines 41, 42, 43 and further in the 'Examples' section), there is an unnecessary space after the '$' prefix. For clarity and to avoid any potential confusion, please remove the extra space so that the '$' immediately precedes the expression (e.g., use '$steps[0].input.a' instead of '$ steps[0].input.a'). - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
30. documentation/concepts/tasks.mdx:203
- Draft comment:
Typographical Issue: The heading "## How to Use Tasks ?" has an unnecessary space before the question mark. Consider changing it to "## How to Use Tasks?" for a cleaner look. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
31. documentation/concepts/tools.mdx:220
- Draft comment:
Typo detected: 'utlize' should be corrected to 'utilize' to improve clarity. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
32. documentation/concepts/users.mdx:166
- Draft comment:
There's a minor typographical issue on line 166 in the Tip block. The SDK reference text appears to be missing a closing parenthesis after the [JavaScript] link. Please update it to match the expected format, e.g., 'SDK reference (Python or JavaScript)' so that the links are properly enclosed. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
33. documentation/guides/getting-started/create-and-execute-julep-task.mdx:678
- Draft comment:
Consider rewording the Tasks link description. Instead of "Learn about Julep tasks in more details and see other tasks steps", you might say "Learn about Julep tasks in more detail and view additional task steps" or similar for improved clarity. - Reason this comment was not posted:
Comment was on unchanged code.
34. documentation/integrations/contributing-integrations.mdx:21
- Draft comment:
There is an inconsistency in the directory naming between steps 3 and 4: step 3 refers tointegration-service/integrations/utils/integrationswhile step 4 usesintegrations-service/integrations/providers.py. Please verify and correct this if it is a typo. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
35. documentation/integrations/mediafile/llamaparse.mdx:72
- Draft comment:
Typo: In the YAML Explanation under the 'Tool Configuration' accordion, consider changing "Contains configuration Details" to "Contains configuration details" for consistency. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
36. documentation/integrations/search/brave.mdx:4
- Draft comment:
It appears that the icon name 'searchengin' might be a typographical error. Consider correcting it to 'searchengine' (unless 'searchengin' is an intentional naming choice) to ensure consistency. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
37. documentation/integrations/search/wikipedia.mdx:25
- Draft comment:
There is an extra label appended to the code fence on line 25 ('yaml Wikipedia Search Example'). Typically, the fence should only include the language (e.g., 'yaml'). Removing 'Wikipedia Search Example' may help tools and editors correctly highlight the YAML content. - Reason this comment was not posted:
Comment was on unchanged code.
38. documentation/integrations/supported-integrations.mdx:28
- Draft comment:
Typographical suggestion: Consider changing 'Cloud based Image and Video Processing' to 'Cloud-based image and video processing' for consistency and correct usage. The term 'Cloud-based' is the standard hyphenated adjective form. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50% Looking at the rules, we should not make purely informative comments or comments about obvious things. While the suggestion is technically correct, it's a very minor style issue in documentation. The meaning is perfectly clear either way. This seems like the kind of nitpicky comment that adds noise without significant value. The suggested change would make the documentation more professional and consistent. Poor formatting in documentation could reflect badly on the project. While consistency is good, this is an extremely minor formatting issue that doesn't impact understanding. The rules specifically say to avoid obvious or unimportant comments. This comment should be deleted as it's too minor and doesn't highlight a significant issue that needs addressing.
39. documentation/integrations/supported-models.mdx:102
- Draft comment:
There's a typographical error in the description for 'llama-4-scout-17b-16e-instruct'. 'Deployements' should be corrected to 'deployments'. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is purely informative and suggests a correction in the description, which is not relevant to the code functionality. It doesn't provide a code suggestion or ask for a test, so it should be removed.
40. documentation/integrations/supported-models.mdx:123
- Draft comment:
There's a typographical error in the 'Supported Parameters' section where 'paramters' is used. It should be spelled 'parameters'. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
41. documentation/integrations/webbrowser/browserbase.mdx:47
- Draft comment:
The YAML snippet in the 'Create Task Definition' step uses quotes for theapi_key(line 42) but not for theproject_idin theargumentssection (line 47). For consistency and clarity, consider quotingBROWSERBASE_PROJECT_IDas well. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50% While consistency in documentation examples is good, this is a very minor formatting issue. Both quoted and unquoted strings are valid YAML. The example will work either way. The comment doesn't point out a bug or significant code quality issue. The inconsistency could potentially confuse readers about when quotes are required in YAML. Some might wonder if there's a functional difference. While there could be minor confusion, this is too trivial an issue to warrant a PR comment. YAML basics like quoted vs unquoted strings are well documented elsewhere. Delete the comment as it points out a very minor formatting inconsistency that doesn't affect functionality or significantly impact documentation clarity.
42. documentation/integrations/webbrowser/browserbase.mdx:2
- Draft comment:
There is an inconsistency in naming: the title uses 'Browser Base' (with a space) while the Info sections and other parts of the document refer to the integration as 'Browserbase' (no space). Consider standardizing the naming throughout the document for clarity. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
43. documentation/integrations/webbrowser/remote-browser.mdx:15
- Draft comment:
Typographical error: The phrase "the that remote browser" in line 15 is redundant. Consider removing one of the articles (probably remove 'the' so it reads 'that remote browser'). - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
44. documentation/integrations/webbrowser/spider.mdx:44
- Draft comment:
Typo detected: 'this a placeholder' should be corrected to 'this is a placeholder' for clarity. - Reason this comment was not posted:
Comment was on unchanged code.
45. documentation/julepcli/introduction.mdx:14
- Draft comment:
Typographical error: The code block fence on line 14 reads "bash pip". It seems that "pip" was mistakenly added. It should likely just be "bash" to correctly denote a bash code block. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
46. documentation/julepcli/introduction.mdx:92
- Draft comment:
Typographical error: The phrase "There are bunch of templates" on line 92 might be clearer as "There are a bunch of templates". Consider adding the missing article for improved readability. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
47. documentation/responses/examples.mdx:63
- Draft comment:
Typo detected: The language identifier for the code block is written as 'python Python'. It should simply be 'python' to ensure proper syntax highlighting. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
48. documentation/responses/examples.mdx:59
- Draft comment:
Typographical error: The example output ends with '8..' (two periods). Consider removing the extra period to read '8.' for better clarity. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
49. documentation/responses/quickstart.mdx:191
- Draft comment:
There's a typographical error in the block: "To learn more about the CLI one can use the checkout the CLI Documentation." It seems there is an extra or misplaced word. Consider rephrasing it to something like "To learn more about the CLI, check out the CLI Documentation." - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
50. documentation/responses/roadmap.mdx:102
- Draft comment:
It appears that 'Computer Tool Call Support' may contain a typographical error. Should 'Computer' be 'Component' or another intended term? Please clarify. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
51. documentation/tutorials/browser-use.mdx:369
- Draft comment:
Typo: The text "Juelp Browser Use Agent" appears to contain a spelling error. It should be "Julep Browser Use Agent" to maintain consistency with the repository and documentation. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 0% vs. threshold = 50% The typo is in a string that's used internally for session creation. While it is technically a misspelling, it doesn't affect functionality since this is just a descriptive string used for logging/debugging. The string appears in a tutorial/documentation file but isn't user-facing content that would confuse readers since it's in a code example. The typo could potentially confuse readers of the documentation who are trying to understand the code examples. It's in a tutorial meant to teach users. While it's in a tutorial, this particular string is an implementation detail in a code example, not instructional text. The typo doesn't impact understanding of the concepts being taught. The comment should be deleted as it points out a minor typo that doesn't affect functionality or tutorial comprehension.
52. documentation/tutorials/rag-chatbot.mdx:135
- Draft comment:
Typo: The variable 'succint' is used in multiple places to join the chunks, but it should be spelled 'succinct'. Please update this spelling for clarity. - Reason this comment was not posted:
Comment was on unchanged code.
53. documentation/tutorials/rag-chatbot.mdx:328
- Draft comment:
Typographical error in the Python code sample: The 'input' dictionary for creating an execution is missing a closing quote in the URL string. It appears as: input={"url": "https://en.wikipedia.org/wiki/Artificial_intelligence, "reducing_strength": 5} It should be corrected to: input={"url": "https://en.wikipedia.org/wiki/Artificial_intelligence", "reducing_strength": 5} - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
54. documentation/tutorials/video-processing.mdx:243
- Draft comment:
Typographical Error: In the prompt text, 'medial url' should be corrected to 'media URL' for clarity. - Reason this comment was not posted:
Comment was on unchanged code.
55. documentation/tutorials/video-processing.mdx:243
- Draft comment:
Typographical Error: In the prompt text, please change "an overlay an the following image" to "an overlay on the following image", and remove the duplicate 'to' in "I want you to to blur the video". These changes improve readability. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
56. hasura/docker-compose.yml:28
- Draft comment:
Minor style issue: The file is missing a trailing newline at the end. Consider adding a newline at the end of the file to comply with common file formatting expectations. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50% While missing trailing newlines can cause issues with some tools and is generally considered good practice, this is a very minor formatting issue that would likely be caught by linters or formatters. It's not a logic issue or code quality concern that significantly impacts the functionality. The comment is technically correct and follows a common convention. Missing newlines can cause issues with some Git operations and tools. However, this is exactly the kind of minor formatting issue that should be handled by automated tools rather than manual review comments. It doesn't affect the logic or functionality of the docker-compose configuration. The comment should be removed as it's too minor and would be better handled by automated formatting tools.
57. integrations-service/docker-compose.yml:4
- Draft comment:
The key 'x--shared-environment' has a double dash; consider renaming it to 'x-shared-environment' for consistency and to avoid confusion. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
58. llm-proxy/litellm-config.yaml:216
- Draft comment:
Typo: In the Cerebras models section, the model value on line 216 is "cerebras/llama3.1-8b" but the model name is "cerebras/llama-3.1-8b" (with a missing hyphen). Please update it to match the intended name. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
59. memory-store/migrations/000036_usage.down.sql:16
- Draft comment:
There's no newline at the end of the file. While this is a very minor, cosmetic issue, adding a newline at the end of the file can help avoid potential warnings in some development environments. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%The comment is purely informative, suggesting adding a newline to avoid potential warnings. It doesn't provide a specific code suggestion or ask for a test to be written. It doesn't align with the rules for good comments.
60. memory-store/migrations/000036_usage.down.sql:10
- Draft comment:
The error message on line 10 reads "An error occurred during deleting all from usage: %, %". Consider rephrasing it for clarity (e.g., "An error occurred while deleting all rows from usage: %, %") to improve readability. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50% This is a minor wording suggestion in an error message that would only be seen during migration failures. While the suggested wording is marginally better, this kind of minor text change doesn't affect functionality and isn't worth the overhead of a code change. Error messages don't need to be perfect as long as they're clear enough to understand the issue. The suggested wording is technically more grammatically correct and could make the error slightly clearer to developers debugging migration issues. However, the existing message is already clear enough to understand what failed, and this kind of minor text improvement doesn't justify the overhead of a code change and review cycle. Delete this comment as it suggests a minor text improvement that doesn't meaningfully impact code quality or functionality.
61. typespec/tools/models.tsp:77
- Draft comment:
Typographical error: the word 'overriden' should be spelled 'overridden' in the comment for the 'name' field. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
62. typespec/tools/models.tsp:80
- Draft comment:
Typographical error: the word 'overriden' should be spelled 'overridden' in the comment for the 'description' field. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
Workflow ID: wflow_2XaoDtslS5bGAzJ6
You can customize 
| @@ -137,6 +137,34 @@ class CreateOrUpdateAgentRequest(CreateAgentRequest): | |||
| """ | |||
|
|
|||
|
|
|||
| class ListModelsResponse(BaseModel): | |||
| - **Minor Fix**: Resolved documentation formatting issues in 21 files 🔧 | ||
| - **Major Enhancement**: Refactored API calls to include developer ID for better tracking 📈 | ||
| - **Minor Enhancement**: Improved Gunicorn worker configurability via environment variables 📈 | ||
| - **Secondary Performance**: Integrated OpenAPI model and TyeSpecs for expanded functionality 🚀 |
There was a problem hiding this comment.
Typographical error: TyeSpecs appears to be a typo. Consider verifying if this should be TypeSpecs.
Suggested change
| - **Secondary Performance**: Integrated OpenAPI model and TyeSpecs for expanded functionality 🚀 | |
| - **Secondary Performance**: Integrated OpenAPI model and TypeSpecs for expanded functionality 🚀 |
| index_name: your_index_name # this is a placeholder for the actual index name | ||
| query: searchquery # this is a placeholder for the actual search query | ||
| hits_per_page: 10 | ||
| attributes_to_retrieve: $ ["attribute1", "attribute2"] # this is a placeholder for the actual attributes to retrieve |
There was a problem hiding this comment.
In the YAML snippet, the line attributes_to_retrieve: $ ["attribute1", "attribute2"] contains an extraneous $. This could cause issues with YAML parsing. Consider removing the $ so the line reads: attributes_to_retrieve: ["attribute1", "attribute2"].
Suggested change
| attributes_to_retrieve: $ ["attribute1", "attribute2"] # this is a placeholder for the actual attributes to retrieve | |
| attributes_to_retrieve: ["attribute1", "attribute2"] # this is a placeholder for the actual attributes to retrieve |
| * You are already inside the browser. | ||
| * You can't open new tabs or windows. | ||
| * For now, rely on screenshots as the only way to see the browser. | ||
| * You can't don't have access to the browser's UI. |
There was a problem hiding this comment.
Typo: The text You can't don't have access to the browser's UI. should be corrected to either You don't have access to the browser's UI. or You can't access the browser's UI.. Please fix the phrasing.
Suggested change
| * You can't don't have access to the browser's UI. | |
| * You don't have access to the browser's UI. |
CI Feedback 🧐A test triggered by this PR failed. Here is an AI-generated analysis of the failure:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Enhancement, Tests, Documentation, Configuration changes
Description
Introduced Mailgun integration across API, schema, and type definitions, enabling email sending via Mailgun and supporting new setup/argument/output models.
Added comprehensive usage tracking for LLM and embedding APIs, including new utilities, database schema (usage table), and cost calculation logic.
Implemented new endpoint and models for listing available agent models.
Enhanced error handling for query parameters, references, and validation errors, including new exception types and improved HTTP error mapping.
Refactored query parameter validation to use annotated types and reusable validators across multiple listing endpoints.
Added and expanded test coverage for invalid query parameters, error scenarios, usage tracking, and new API features.
Added service health check utilities and refactored health endpoint for concurrent checks and detailed status reporting.
Updated Gunicorn worker configuration to use environment variables and CPU count in both API and integration services.
Added and updated configuration files: docker-compose, LiteLLM model config, Hasura metadata, and environment variables.
Added and improved documentation: new advanced and integration pages, tutorials, and fixed links/formatting in existing docs.
Updated cookbooks and notebooks for improved API key handling, output consistency, and template usage.
Added TypeSpec definitions for Mailgun and updated schemas for new integration and document search parameters.
Changes walkthrough 📝
31 files
Agents.py
Add model listing response and info Pydantic modelsagents-api/agents_api/autogen/Agents.py
ListModelsResponseandModelInfofor modellisting API responses.
Tools.py
Add Mailgun integration and API call response content optionagents-api/agents_api/autogen/Tools.py
integration definitions.
and patch requests.
include_response_contentfield toApiCallDefandApiCallDefUpdate.usage.py
Add utilities for tracking LLM and embedding API usageagents-api/agents_api/common/utils/usage.py
track_usageandtrack_embedding_usagefortracking LLM and embedding API usage.
create_usage_record.create_usage_record.py
Add create_usage_record for tracking LLM API usage and costsagents-api/agents_api/queries/usage/create_usage_record.py
create_usage_recordto insert usage/cost recordsinto the database.
fails.
Tools.py
Add Mailgun integration and API call response content option(integrations-service)integrations-service/integrations/autogen/Tools.py
integration definitions.
and patch requests.
include_response_contentfield toApiCallDefandApiCallDefUpdate.execution.py
Add Mailgun support to execution models and outputsintegrations-service/integrations/models/execution.py
mailgun.py
Add Mailgun integration utility for sending emailsintegrations-service/integrations/utils/integrations/mailgun.py
litellm.py
Add usage tracking for completions and embeddings in LiteLLM clientagents-api/agents_api/clients/litellm.py
track_usageandtrack_embedding_usageafter API calls.tracking fails.
validation.py
Add QueryParamsValidationError exception for query parametervalidationagents-api/agents_api/common/exceptions/validation.py
QueryParamsValidationErrorfor queryparameter validation errors.
checks.py
Add service health check utilities for health endpointagents-api/agents_api/common/utils/checks.py
Integration service.
__init__.py
Import usage module into queries packageagents-api/agents_api/queries/init.py
usagemodule into the queries package.list_docs.py
Use annotated type validation for list_docs query parametersagents-api/agents_api/queries/docs/list_docs.py
limitandoffsetparameters.
make_num_validator.list_entries.py
Use annotated type validation for list_entries query parametersagents-api/agents_api/queries/entries/list_entries.py
limitandoffsetparameters, allowing up to 1000 entries.
make_num_validator.list_executions.py
Use annotated type validation for list_executions query parametersagents-api/agents_api/queries/executions/list_executions.py
limitandoffsetparameters.
make_num_validator.list_files.py
Use annotated type validation for list_files query parametersagents-api/agents_api/queries/files/list_files.py
limitandoffsetparameters.
make_num_validator.list_tasks.py
Use annotated type validation for list_tasks query parametersagents-api/agents_api/queries/tasks/list_tasks.py
limitandoffsetparameters.
make_num_validator.__init__.py
Add usage tracking module with create_usage_record exportagents-api/agents_api/queries/usage/init.py
tracking module.
create_usage_recordfrom the module.list_users.py
Use annotated type validation for list_users query parametersagents-api/agents_api/queries/users/list_users.py
limitandoffsetparameters.
make_num_validator.utils.py
Add make_num_validator utility for parameter validationagents-api/agents_api/queries/utils.py
make_num_validatorfunction for reusable numeric validation.QueryParamsValidationError.__init__.py
Import list_models endpoint in agents routeragents-api/agents_api/routers/agents/init.py
list_modelsendpoint to the agents router module.list_models.py
Add endpoint to list available agent modelsagents-api/agents_api/routers/agents/list_models.py
/agents/modelsto list all available models foragents.
key.
ListModelsResponsewith model info.check_health.py
Refactor healthz endpoint to use concurrent service checksagents-api/agents_api/routers/healthz/check_health.py
utilities.
service is degraded.
Agents.py
Add model listing response models to Agents APIintegrations-service/integrations/autogen/Agents.py
ListModelsResponseandModelInfoPydantic models for modellisting endpoint.
__init__.py
Add MailgunSendEmailOutput to models packageintegrations-service/integrations/models/init.py
MailgunSendEmailOutputto models package.mailgun.py
Add MailgunSendEmailOutput model for email integrationintegrations-service/integrations/models/mailgun.py
MailgunSendEmailOutputfor Mailgun email sendingresults.
providers.py
Add Mailgun provider and register in available providersintegrations-service/integrations/providers.py
create_agent_request.json
Add Mailgun integration and new doc search parameters to schemaschemas/create_agent_request.json
trigram_similarity_threshold).
include_response_contentto API call schemas.create_task_request.json
Add Mailgun integration and new doc search parameters to schemaschemas/create_task_request.json
trigram_similarity_threshold).
include_response_contentto API call schemas.execute_api_call.py
Add include_response_content option to API call executionagents-api/agents_api/activities/execute_api_call.py
include_response_contentin API call execution.b64encodefrombase64.000036_usage.up.sql
Add migration for usage tracking table in memory storememory-store/migrations/000036_usage.up.sql
usagetable for tracking tokenusage and costs.
time-series queries.
mailgun.tsp
Add TypeSpec definition for Mailgun integrationtypespec/tools/mailgun.tsp
output models for Mailgun.
1 files
db_exceptions.py
Improve error handling for query parameter and reference errorsagents-api/agents_api/common/utils/db_exceptions.py
directions.
violations.
with detailed messages.
9 files
test_docs_queries.py
Add tests for invalid doc listing parameters and missing referencesagents-api/tests/test_docs_queries.py
in
list_docsfor users and agents.user/agent references.
test_entry_queries.py
Add tests for invalid entry listing parameters and error handlingagents-api/tests/test_entry_queries.py
list_entries.parameters.
test_execution_queries.py
Add tests for invalid execution listing parameters and error handlingagents-api/tests/test_execution_queries.py
list_executions.parameters.
test_files_queries.py
Add tests for invalid file listing parameters and error handlingagents-api/tests/test_files_queries.py
list_files.parameters.
test_task_execution_workflow.py
Add tests for API call tool response content inclusionagents-api/tests/test_task_execution_workflow.py
include_response_contentsettings.results.
test_task_queries.py
Add tests for invalid task listing parameters and error handlingagents-api/tests/test_task_queries.py
list_tasks.parameters.
test_usage_tracking.py
Add comprehensive tests for usage tracking and cost calculationagents-api/tests/test_usage_tracking.py
create_usage_record,track_usage, andtrack_embedding_usageforvarious models and scenarios.
test_user_queries.py
Add tests for invalid user listing parameters and error handlingagents-api/tests/test_user_queries.py
list_users.parameters.
test_agent_queries.py
Add test for invalid sort direction in list_agents querytests/test_agent_queries.py
expecting an HTTP 400 error.
4 files
00-Devfest-Email-Assistant.ipynb
Update notebook outputs and template variable usage for emailassistantcookbooks/00-Devfest-Email-Assistant.ipynb
results.
02-sarcastic-news-headline-generator.ipynb
Improve API key handling and update notebook outputs for headlinegeneratorcookbooks/02-sarcastic-news-headline-generator.ipynb
05-video-processing-with-natural-language.ipynb
Improve API key handling and update video processing notebook outputscookbooks/05-video-processing-with-natural-language.ipynb
06-browser-use.ipynb
Fix browser goal formatting and update notebook metadatacookbooks/06-browser-use.ipynb
7 files
env.py
Add Gunicorn worker configuration based on CPU and env varsagents-api/agents_api/env.py
variables.
gunicorn_cpu_divisorandgunicorn_workersvariables.gunicorn_conf.py
Use gunicorn_workers from environment for Gunicorn configagents-api/gunicorn_conf.py
gunicorn_workersfromenvironment.
multiprocessing.cpu_count().docker-compose.yml
Update docker-compose to use hasura instead of graphqldocker-compose.yml
graphql/docker-compose.ymltohasura/docker-compose.yml.hasura_metadata_2025_04_07_16_21_57_118.json
Add Hasura metadata for database schema and permissionshasura/metadata/hasura_metadata_2025_04_07_16_21_57_118.json
permission configurations.
gunicorn_conf.py
Use gunicorn_workers from environment for Gunicorn configintegrations-service/gunicorn_conf.py
gunicorn_workersfromenvironment.
multiprocessing.cpu_count().env.py
Add Gunicorn and Mailgun config to integrations envintegrations-service/integrations/env.py
variables.
mailgun_api_keyenvironment variable.litellm-config.yaml
Add new Gemini, OpenRouter, and Cerebras models to LiteLLM configllm-proxy/litellm-config.yaml
gemini-2.5-pro-preview-03-25).
their free variants).
10 files
docs.mdx
Update and fix documentation links and code formattingdocumentation/concepts/docs.mdx
SDKs.
browser-use.mdx
Add tutorial for browser automation with Julepdocumentation/tutorials/browser-use.mdx
task examples and SDK usage.
Node.js.
rag-chatbot.mdx
Improve formatting and links in RAG chatbot tutorialdocumentation/tutorials/rag-chatbot.mdx
agentic-patterns.mdx
New documentation page on agentic workflow patterns and best practicesdocumentation/advanced/agentic-patterns.mdx
patterns.
chaining, routing, parallelization, orchestrator-workers, and
evaluator-optimizer patterns.
agents.
architecture-deep-dive.mdx
New documentation page for Julep architecture deep divedocumentation/advanced/architecture-deep-dive.mdx
Julep.
features.
files.mdx
New documentation page for file handling and managementdocumentation/advanced/files.mdx
Julep.
localsetup.mdx
New documentation page for local setup instructionsdocumentation/advanced/localsetup.mdx
multi-agent-multi-user-sessions.mdx
New documentation page for multi-agent multi-user sessionsdocumentation/advanced/multi-agent-multi-user-sessions.mdx
session management.
scenarios.
new-syntax.mdx
New documentation page for workflow syntax changes and migrationdocumentation/advanced/new-syntax.mdx
of the $ prefix.
supported-integrations.mdx
New documentation page listing supported integrationsdocumentation/integrations/supported-integrations.mdx
Julep.
62 files