Skip to content

Fixed angular element children selector usage #605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fixed angular element children selector usage #605

wants to merge 1 commit into from

Conversation

aklinkert
Copy link

In jqLite, .children() selector is not able to take an selector argument. Caused by this error, the directive is removing all children, if no full jQuery is used.

@aklinkert
Copy link
Author

Broken tests also broken in develop. ;)

@aklinkert aklinkert changed the title FFixed angular element children selector usage Fixed angular element children selector usage Dec 14, 2015
@Anthropic
Copy link
Member

@apinnecke thank you for the PR, I'm fairly new to managing the project and we are slowly starting to ramp back up and reviewing some neglected PRs, is there any chance you could write a test script for the change? It would be a huge help :)

Also please don't include the dist folder in the PR, we only update those on release.

ps. yes the test script has 4 tests that fail every time, I am going to look at sorting those out soon :)

@aklinkert
Copy link
Author

Unfortunately I'm very much out of time these days. Ya, probably could write some tests, but can't tell when that will be. Plus: This change is already covered by the original tests AFAIK, so maybe these are enough? Has to be verified indeed.

@nicklasb
Copy link
Member

nicklasb commented Oct 6, 2016

@apinnecke Do you have some time to give some love to this PR?

@Anthropic
Copy link
Member

@apinnecke thank you for the PR I finally got to it, I can't merge due to the number of changes since but I added the change to sf-schema.directive.js so thank you again for your help.

Anthropic added a commit that referenced this pull request Feb 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants