Skip to content

chore: simplify test with t.Setenv #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 27, 2025
Merged

chore: simplify test with t.Setenv #129

merged 1 commit into from
Jan 27, 2025

Conversation

alexandear
Copy link
Contributor

@alexandear alexandear commented Jan 15, 2025 •
edited
Loading

The PR refactors TestRunWithInputs by changing to use https://pkg.go.dev/testing#T.Setenv instead of os.Setenv:

Setenv calls os.Setenv(key, value) and uses Cleanup to restore the environment variable to its original value after the test.

This is detected with tenv linter.

@alexandear alexandear requested a review from joerdav as a code owner January 15, 2025 16:31
@joerdav joerdav merged commit 56ebe49 into joerdav:main Jan 27, 2025
3 checks passed
@alexandear alexandear deleted the chore/t-setenv branch January 27, 2025 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joerdav joerdav Awaiting requested review from joerdav joerdav is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexandear @joerdav