Add note for reroute-virtual-interfaces usage with dind #3494
Conversation
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
|
😊 Welcome @sridhargaddam! This is either your first contribution to the Istio api repo, or it's been You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines Thanks for contributing! Courtesy of your friendly welcome wagon. |
istio-testing
added
the
size/XS
sridhargaddam
added
the
release-notes-none
|
/test release-notes |
|
Motivation behind the PR: https://istio.slack.com/archives/C37A4KAAD/p1745070788535839?thread_ts=1744990810.376149&cid=C37A4KAAD |
annotation/annotations.yaml
Outdated
| @@ -578,6 +578,7 @@ annotations: | |||
| featureStatus: Alpha | |||
| description: | | |||
| A comma separated list of virtual interfaces whose inbound traffic will be unconditionally treated as outbound. This allows workloads using virtualized networking (kubeVirt, VMs, docker-in-docker, etc) to function correctly with mesh traffic capture. | |||
| Note: In the case of docker-in-docker containers, the default Docker bridge name is not fixed. To have a predictable name, you can configure the Docker option `com.docker.network.bridge.name` with a fixed value and use that name in the annotation. | |||
There was a problem hiding this comment.
| Note: In the case of docker-in-docker containers, the default Docker bridge name is not fixed. To have a predictable name, you can configure the Docker option `com.docker.network.bridge.name` with a fixed value and use that name in the annotation. | |
| Note: When using docker-in-docker container, the default bridge interface name is typically `docker0`. However, custom networks (often used with docker compose) are assigned a randomized interface name. To have a predictable name, you can configure the Docker option `com.docker.network.bridge.name` with a fixed value and use that name in the annotation. |
There was a problem hiding this comment.
I'd suggest putting in a full docker-compose example... eg:
networks:
custom_bridge:
driver: bridge
driver_opts:
com.docker.network.bridge.name: "istio-docker0" << point out that this needs to be done in conjunction with the annotationThere was a problem hiding this comment.
Thank you @howardjohn.
@diranged it looks a bit too verbose for a note. But if John/others, feel that including the full networks section is fine, I'm happy to update the PR.
There was a problem hiding this comment.
I agree it is a bit verbose, could we host the special instruction as the example in the doc instead?
There was a problem hiding this comment.
I tried searching the current docs but couldn't find an appropriate section where this note could be added.
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
|
lgtm - proposed change from John. |
No description provided.